Change PollDaddy embed to Crowdsignal #13180
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Soean
requested changes
Jan 3, 2019
geekpulp
changed the title
Soean
reviewed
Jan 4, 2019
| @@ -0,0 +1,2 @@ | |||
| { | |||
There was a problem hiding this comment.
I don't think this file should be added?!
There was a problem hiding this comment.
Indeed. @geekpulp You should add .vscode to your global .gitignore file :-)
|
Duplicate of #12854 ? |
swissspidy
added
the
[Status] Duplicate
|
Indeed a duplicate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change the Polldaddy embed block to Crowdsignal (Their new brand) by updating core-embeds.js.
Fixes #11517.
How has this been tested?
Tested in Safari 12.0.2, added a poll to the page using the embed. updated branded presented correctly
The standard docker environment was used for testing
This change doesn't affect other areas of the code
Screenshots
Types of changes
Content change for updated branding of a service
Checklist: