Replace Polldaddy embed block with Crowdsignal #12854
Conversation
| @@ -227,13 +245,14 @@ export const others = [ | |||
| patterns: [ /^http:\/\/g?i*\.photobucket\.com\/.+/i ], | |||
| }, | |||
| { | |||
| // Deprecated in favour of the core-embed/crowdsignal block | |||
There was a problem hiding this comment.
I'm not sure if we can remove the pattern because of backward compatibility. However we can hide the deprecated version from the inserter. We did that for subheading block and the old version of columns block.
There was a problem hiding this comment.
Removing the patterns here is fine, they're only used to resolve URLs into the correct block, so existing blocks are loaded, and converted to the Crowdsignal block without a problem.
I'm not sure we should hide the old block either. It's useful for people who still have the polldaddy name in their minds, and if they use the polldaddy block, it'll convert to a crowdsignal block automatically.
There was a problem hiding this comment.
You can resolve it by adding a keyword to the new block.
There was a problem hiding this comment.
That doesn't help people scrolling through the list instead of typing to search though.
There was a problem hiding this comment.
Yes, true. That’s the broader issue with rebranding 😅 I will leave it up to you. We should have some consistent strategy for depreciations.
There was a problem hiding this comment.
I think it's fine to remove it from the inserter, check the deprecation of core-embed/speaker in favour of core-embed/speaker-deck.
For people still looking for "Polldaddy", perhaps add "formerly Polldaddy" to the description of the new Crowdsignal block, and maybe to the name, too.
There was a problem hiding this comment.
ac09b7c - removed from the inserter similar to core-embed/speaker as suggested
There was a problem hiding this comment.
b9584b6 - added formerly Polldaddy to the description
There was a problem hiding this comment.
d0b2233 - added polldaddy keyword for better discoverability of the new block
|
Note that the renaming has been done in Core already, so this PR needs to be finished/merged in time for WordPress 5.1. |
ice9js
force-pushed
the
add/crowdsignal-embed
branch
from
fa26800
to
60cdd07
Compare
|
I rebased the branch and resolved conflicts. |
|
@youknowriad and @pento - it looks like it wasn’t included in WordPress 5.1 beta, is it something that needs to be fixed? |
|
Sanity check, is this ready to land? I'm planning to update Core today, so this needs to lands ASAP :) |
|
@ice9js congratulations on your first contribution to Gutenberg 🎉 💯 I will merge this PR as soon as Travis CI will turn green. |
* Replace Polldaddy embed block with Crowdsignal * Remove Polldaddy from the inserter * Update core-embeds.js * Update core-embeds.js * Update core-embeds.js
Description
Given the recent rebranding of Polldaddy to Crowdsignal, this change replaces the existing Polldaddy embed type with Crowdsignal and updates the pattern to match Crowdsignal's updated URLs for polls and surveys.
Solves #11517.
How has this been tested?
Before applying my changes, add a post with the current Polldaddy embed block.
After the changes have been applied the block should be automatically upgraded to Crowdsignal.
There should now also be a new
Crowdsignalembed block available from the menu.All current poll and survey links from Crowdsignal should trigger the Crowdsignal embed block when pasted directly into the editor, for example:
I have tested this locally.
Screenshots
Types of changes
New feature: Added a Crowdsignal embed block
Checklist: