Fix exception when editing non-public CPTs

docs/designers-developers/developers/data/data-core-editor.md

@@ -1292,19 +1292,21 @@ Returns the permalink for the post.
 
 *Returns*
 
-The permalink.
+The permalink, or null if the post is not viewable.
 
 ### getPermalinkParts
 
-Returns the permalink for a post, split into it's three parts: the prefix, the postName, and the suffix.
+Returns the permalink for a post, split into it's three parts: the prefix,
+the postName, and the suffix.
 
 *Parameters*
 
  * state: Editor state.
 
 *Returns*
 
-The prefix, postName, and suffix for the permalink.
+An object containing the prefix, postName, and suffix for
+                 the permalink, or null if the post is not viewable.
 
 ### inSomeHistory
 

lib/rest-api.php

@@ -206,6 +206,11 @@ function gutenberg_add_permalink_template_to_posts( $response, $post, $request )
 		return $response;
 	}
 
+	$post_type_obj = get_post_type_object( $post->post_type );
+	if ( ! is_post_type_viewable( $post_type_obj ) || ! $post_type_obj->public ) {
+		return $response;
+	}
+
 	if ( ! function_exists( 'get_sample_permalink' ) ) {
 		require_once ABSPATH . '/wp-admin/includes/post.php';
 	}

packages/editor/src/store/selectors.js

@@ -2119,10 +2119,15 @@ export function isPermalinkEditable( state ) {
  *
  * @param {Object} state Editor state.
  *
- * @return {string} The permalink.
+ * @return {?string} The permalink, or null if the post is not viewable.
  */
 export function getPermalink( state ) {
-	const { prefix, postName, suffix } = getPermalinkParts( state );
+	const permalinkParts = getPermalinkParts( state );
+	if ( ! permalinkParts ) {
+		return null;
+	}
+
+	const { prefix, postName, suffix } = permalinkParts;
 
 	if ( isPermalinkEditable( state ) ) {
 		return prefix + postName + suffix;
@@ -2132,14 +2137,20 @@ export function getPermalink( state ) {
 }
 
 /**
- * Returns the permalink for a post, split into it's three parts: the prefix, the postName, and the suffix.
+ * Returns the permalink for a post, split into it's three parts: the prefix,
+ * the postName, and the suffix.
  *
  * @param {Object} state Editor state.
  *
- * @return {Object} The prefix, postName, and suffix for the permalink.
+ * @return {Object} An object containing the prefix, postName, and suffix for
+ *                  the permalink, or null if the post is not viewable.
  */
 export function getPermalinkParts( state ) {
 	const permalinkTemplate = getEditedPostAttribute( state, 'permalink_template' );
+	if ( ! permalinkTemplate ) {
+		return null;
+	}
+
 	const postName = getEditedPostAttribute( state, 'slug' ) || getEditedPostAttribute( state, 'generated_slug' );
 
 	const [ prefix, suffix ] = permalinkTemplate.split( PERMALINK_POSTNAME_REGEX );

packages/editor/src/store/test/selectors.js

@@ -5042,6 +5042,17 @@ describe( 'selectors', () => {
 
 			expect( getPermalink( state ) ).toBe( 'http://foo.test/bar/baz/' );
 		} );
+
+		it( 'should return null if the post has no permalink template', () => {
+			const state = {
+				currentPost: {},
+				editor: {
+					present: {},
+				},
+			};
+
+			expect( getPermalink( state ) ).toBeNull();
+		} );
 	} );
 
 	describe( 'getPermalinkParts', () => {
@@ -5087,6 +5098,17 @@ describe( 'selectors', () => {
 
 			expect( getPermalinkParts( state ) ).toEqual( parts );
 		} );
+
+		it( 'should return null if the post has no permalink template', () => {
+			const state = {
+				currentPost: {},
+				editor: {
+					present: {},
+				},
+			};
+
+			expect( getPermalinkParts( state ) ).toBeNull();
+		} );
 	} );
 
 	describe( 'getBlockListSettings', () => {