Fix exception when editing non-public CPTs #12201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changes the posts API endpoint to only set `permalink_template` and `generated_slug` when the post is public and queryable. This matches the behaviour in Core. - Changes the `getPermalink()` and `getPermalinkParts()` selectors to return null when there is no `permalink_template`. This fixes an exception on non-public CPTs caused by attempting to parse an undefined `permalink_template`.
noisysocks
added
[Type] Bug
noisysocks
commented
Nov 22, 2018
| $post_type_obj = get_post_type_object( $post->post_type ); | ||
| if ( ! is_post_type_viewable( $post_type_obj ) || ! $post_type_obj->public ) { | ||
| return $response; | ||
| } |
There was a problem hiding this comment.
I pulled this logic over from the 5.0 branch.
This was referenced May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12129.
permalink_templateandgenerated_slugwhen the post is public and queryable. This matches the behaviour in Core.getPermalink()andgetPermalinkParts()selectors to return null when there is nopermalink_template. This fixes an exception on non-public CPTs caused by attempting to parse an undefinedpermalink_template.Testing