Allow a block to disable being converted into a reusable block; Fix: Column block #11550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Type] Bug
docs/block-api.md
Outdated
| @@ -504,6 +504,14 @@ inserter: false, | |||
| multiple: false, | |||
| ``` | |||
|
|
|||
| - `reusable` (default `true`): A block may want to disable the ability of being converted into a reusable block. | |||
| By default all blocks can be converted to a reusable block if supports reusable is set to false, | |||
| the option to convert the block into a reusable block will not appear. | |||
There was a problem hiding this comment.
Small nit but these should all be one line, no line breaks :)
aduth
approved these changes
Nov 6, 2018
| ( blocks.length !== 1 || ( | ||
| blocks[ 0 ].name !== getFreeformFallbackBlockName() && | ||
| blocks[ 0 ].name !== getUnregisteredFallbackBlockName() | ||
| // Guard against the case where a regular block has *just* been converted to a |
There was a problem hiding this comment.
This comment now only really covers part of what's being done with the every condition. We might want to enhance it slightly, or even move it to cover the specific parts of the predicate for which it is relevant (!! block && block.isValid, with complementing comment for the hasBlockSupport check).
| // Hide 'Add to Reusable Blocks' on Classic blocks. Showing it causes a | ||
| // confusing UX, because of its similarity to the 'Convert to Blocks' button. | ||
| ( blocks.length !== 1 || ( | ||
| blocks[ 0 ].name !== getFreeformFallbackBlockName() && |
There was a problem hiding this comment.
I like that we formalize this on the blocks API rather than ad hoc exemptions 👍
|
|
||
| const blocks = map( clientIds, ( clientId ) => getBlock( clientId ) ); | ||
| const blocks = getBlocksByClientId( clientIds ); |
docs/block-api.md
Outdated
| @@ -504,6 +504,14 @@ inserter: false, | |||
| multiple: false, | |||
| ``` | |||
|
|
|||
| - `reusable` (default `true`): A block may want to disable the ability of being converted into a reusable block. | |||
| By default all blocks can be converted to a reusable block if supports reusable is set to false, | |||
There was a problem hiding this comment.
I think this is missing a sentence stop between "block" and "if"
jorgefilipecosta
force-pushed
the
add/flag-that-allows-disable-of-the-converstion-to-reusable-blocks
branch
from
9e127e0
to
e5325fc
Compare
jorgefilipecosta
deleted the
add/flag-that-allows-disable-of-the-converstion-to-reusable-blocks
branch
daniloercoli
added a commit
that referenced
this pull request
Nov 7, 2018
…rnmobile/fix-merge-content-not-refreshed-UI * 'master' of https://github.com/WordPress/gutenberg: Fix the isBeingScheduled Selector. (#11572) Slot/Fill pattern with Toolbar #199 (#11115) Add mechanism to avoid forced child selection on blocks with templates. (#10696) Allow a block to disable being converted into a reusable block; Fix: Column block (#11550)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #10679
This PR adds a flag that allows a block to opt-out being converted into a reusable block as discussed in #10679.
This new logic is used to disable the conversion of column block into a reusable block and to simplify existing logic that disables classic and missing block conversion to reusable blocks.
These simplifications add a behavior change.
Before it was not possible to convert classic or missing block into a reusable block, but if another block was selected with it (even an empty paragraph) it was possible to convert that blocks into reusable blocks, now that's not the case.
If a block that is part of the selection cannot be converted into a reusable block, the option to convert the selected blocks into a reusable block will not be shown.
I think that is the desired behavior.
How has this been tested?
Verify it is not possible to convert to reusable blocks, the "Column" block, the classic block or an invalid block.
Verify it is still possible to convert to reusable blocks the "Columns" block.
Test complex scenarios e.g. multiple selections of Columns and a paragraph, and verify the conversion is possible.