Users can create reusable 'column' block.

[talldan]

Describe the bug
Since #10545 was merged it's now easy for a user to select a column in a columns block. It's also really easy to turn that selected column into a reusable block.

That reusable block can't really be used anywhere, which perhaps makes it worthless, but also it causes layout issues with the columns (see screenshot).

I'm not sure if this has always been possible or if it's a regression. If the former, I wonder if we need a supports.reusable setting in the block api to prevent this?

To Reproduce
Steps to reproduce the behavior:

1. Add a new columns block
2. Add some content to the columns
3. Open the block navigation popover
4. Select one of the 'column' blocks
5. Using the more menu, add the column to reusable blocks
6. Observe that the columns don't maintain their width (see screenshot)

Expected behavior
Either a) the column should not be allowed to be added as a reusable block, or b) the columns should maintain their widths

Screenshots

Additional context

• Gutenberg 4.1

[slimmilkduds]

Deleted my comment since I misread ”column” as ”columns”, sorry!

[mtias]

Makes sense to disable this for "column".

[chrisvanpatten]

Should it be tied to supports.inserter? I'm typically all for more granularity so that doesn't proclude a supports.reusable but it seems safe to assume if you don't support an inserter context, you shouldn't support reusable either.

[noisysocks]

Disabling Add to Reusable Blocks when supports.inserter is truthy falsey sounds 👌 to me.

[noisysocks]

Related: #7882, #10493

[noisysocks]

We talked about adding supports.reusable once but decided against it in #5970.

I'd be 👌 with adding supports.reusable and making core/column and core/freeform have supports.reusable: false. It's more clear now than in April when I opened the aforementioned PR that there is a need for such a property:

1. To disable converting Column blocks to reusable
2. To disable converting Classic blocks to reusable, see Prevent Classic Blocks from being converted to Shared Blocks #5941
3. To fulfil a need expressed by third party plugin developers, see Consider adding reusableBlock to the supports block configuration #4722

[ZebulanStanphill]

Disabling Add to Reusable Blocks when supports.inserter is truthy sounds ok_hand to me.

I think you mean falsy?

Anyway, I would prefer a separate supports.reusable flag, given the desire to make Classic blocks unable to be saved as reusable blocks.

[noisysocks]

I think you mean falsy?

Yes, I do 🙂

[mtias]

Let's add this, but I'm not sure about the support name.