Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring colors by the block for some blocks #20197

Closed
karmatosed opened this issue Feb 12, 2020 · 15 comments
Closed

Bring colors by the block for some blocks #20197

karmatosed opened this issue Feb 12, 2020 · 15 comments
Labels
[Feature] Blocks Overall functionality of blocks Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json

Comments

@karmatosed
Copy link
Member

karmatosed commented Feb 12, 2020

This has been explored in navigation and other blocks, I would like to open the discussion on bringing colors by the block for all blocks. By unifying their place we can start on a path that could see styling out of the sidebar completely.

The problem

Look at how far away and lonely the color options are:

image

I joke a little, however it is a weird experience having to have the sidebar option for this. Shouldn't all these just work right by the block itself?

Existing solutions

I am going to first link what was explored in columns #16660 and similarly in navigation.

1

This is a pretty intense UI and just more or less puts what we have in the sidebar into a drop-down. This is a different space, so that could be iterated leaning on new styling coming in.

Moving into new exploring

I have been doing some thinking around this and how we could perhaps simplify. I came to an iteration feels still forming, but maybe good to share. This isn't meant to be a final design as much as a feedback discussion starter.

v2

A picker would either drop-in/down/or appear, that's not set yet but this does simplify. It could also show more than just theme colours, but there is more space with this tab.

Maybe it also looks like this on hover:

3

There is some work on iterating the color picker so wanted to note that here as I am in this looking to align #19785.

The more I explored this, the stronger I felt moving other options from the sidebar is worth exploring (more to come on that later). If we start though, colors feel like a great starting point.

I will add that unexplored here is what it looks like with both colors 'on'. I will do that in later iterations should we decide this is a great route. My thinking is the circle could show both colors, however, this needs exploring.

Next steps

I would love some feedback around:

  • Is this worth exploring more as a tabbed interface?
  • Is this a good idea to move from the sidebar to by all blocks in the toolbar?
@karmatosed karmatosed added the Needs Design Feedback Needs general design feedback. label Feb 12, 2020
@mtias
Copy link
Member

mtias commented Feb 12, 2020

This has to be intentional based on the role they play for the block and should not be generalized. In the case of a Paragraph block it should not be considered a primary interaction. For a Cover block, on the other hand, it should be easy to access from the toolbar.

Another case in point: the cover block shows colors in the placeholder while paragraph does not.

@karmatosed
Copy link
Member Author

karmatosed commented Feb 12, 2020

Thanks for feedback @mtias. Happy to be wrong about paragraph block. My personal feeling was moving more styling closer to where it happens helps context. As a ponder, how do you feel about a styling section by the block to include over clutter with more options there? Just putting this out there as an idea.

image

For me, the sidebar is a place this is lost and whilst it might not be a primary action I do feel it's a handy thing to have by the block. I keep coming back to having consistent styling in one place could be a benefit. Happy to explore where that could be a wrong turn though.

Let me list where this then could happen to be sure that has some clarity:

  • Column block
  • Cover block
  • Table block (?)
  • Navigation (?)

I put a '?' beside navigation and table, as unsure if this now falls into the division between primary and secondary.

@karmatosed
Copy link
Member Author

As a possible iteration even in sidebar this could be explored:

Frame 14

Very rough mock to show how even if in a different place we could maybe follow a more distilled interface.

@mtias
Copy link
Member

mtias commented Feb 12, 2020

Oh, yes, the tabbed interface is something we should try to combine. It gets a bit tricky when you also have a tabbed interface for solid / gradient on the background tab.

@karmatosed
Copy link
Member Author

Totally agreeing it gets tricky. I'll explore a little more on that then.

@karmatosed karmatosed changed the title Bring colors by the block Bring colors by the block for some blocks Feb 12, 2020
@karmatosed
Copy link
Member Author

Noting changed the title to be 'some blocks' so we can collate and work through a list where the right ones for this are.

@richtabor
Copy link
Member

This has to be intentional based on the role they play for the block and should not be generalized. In the case of a Paragraph block it should not be considered a primary interaction. For a Cover block, on the other hand, it should be easy to access from the toolbar.

Another case in point: the cover block shows colors in the placeholder while paragraph does not.

But at the same time, having different locations for the same controls could be quite jarring to folks - regardless of the selected block. Especially if they're as foundational as changing a design/color.

@ZebulanStanphill
Copy link
Member

I already opened a similar issue: #20070. Should I close it?

@shaunandrews
Copy link
Contributor

having different locations for the same controls could be quite jarring

Agreed. I can't seem to come up with logical reasons for why color controls exist in one place for one block and a different place for a different block; It seems random. I'd imagine most people will not understand, and just assume that a paragraph block doesn't allow color customization.

@mtias
Copy link
Member

mtias commented Feb 16, 2020

It depends, as the color tools do different things depending on context. For example, these mockups are placing block color after the rich text controls, which are based on inline selection (they don't affect the whole block at once).

image

And paragraph already has support for inline color in the "more tools" of the toolbar:

image

@ZebulanStanphill
Copy link
Member

@mtias I think the (not-inline) color control should definitely go before the RichText tools, in order to keep with the currently-established pattern of putting the controls that affect the entire block first in the toolbar.

@mtias
Copy link
Member

mtias commented Feb 16, 2020

Yes, definitely, but that's also why I don't think block color belongs in a paragraph's toolbar, because it gives more prominence to color choices than to rich text tools (bold, italics, etc), which are the most important controls on paragraphs, while making the toolbar as a whole busier. The paragraph block is the most basic text unit we have and should be clear of incidental distractions.

That results in the following clauses for block color:

  • Should not be added after Rich Text tools because it applies at the block level.
  • Should be avoided at the beginning of the paragraph toolbar because it pushes the most important controls.

@ZebulanStanphill
Copy link
Member

@mtias Good point. I think the Paragraph and Heading blocsk can keep the block-level color controls in the inspector. I do think the block-level color controls belong in the toolbar of other blocks like Group or Columns, though.

(I also think it would be good if we could make the inspector more easily accessible and more clearly attached to the selected block somehow.)

@karmatosed karmatosed removed the Needs Design Feedback Needs general design feedback. label May 12, 2020
@annezazu annezazu added [Feature] Blocks Overall functionality of blocks Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json labels May 12, 2020
@oandregal
Copy link
Member

Somehow related, there's #22700 to track the progress of adding style controls to the blocks.

@mtias
Copy link
Member

mtias commented Mar 3, 2021

Let's handle this on a per block basis where it makes sense, like Cover.

@mtias mtias closed this as completed Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json
Projects
None yet
Development

No branches or pull requests

7 participants