Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group and Columns blocks: move color controls to toolbar #20070

Open
ZebulanStanphill opened this issue Feb 6, 2020 · 1 comment
Open

Group and Columns blocks: move color controls to toolbar #20070

ZebulanStanphill opened this issue Feb 6, 2020 · 1 comment
Labels
[Block] Columns Affects the Columns Block [Block] Group Affects the Group Block (and row, stack and grid variants) [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Type] Enhancement A suggestion for improvement.

Comments

@ZebulanStanphill
Copy link
Member

ZebulanStanphill commented Feb 6, 2020

When choosing where to put block controls, the most important ones should be placed either within the block itself (e.g. the caption field of an Image block) or in the toolbar (heading level of a Heading block). Right now, the Group block puts its background and text color controls in the inspector. I think they should be moved to the toolbar for the following reasons:

  • One of the main reasons to use a Group block is to provide a common background color or text color to a group of blocks. This important feature should not be hidden away in the inspector, which is supposed to be reserved for advanced controls.
  • The Group block toolbar is currently very small, so there's more than enough room to put the controls.
  • Putting the color controls in the toolbar makes them more visible and quicker to access.
  • The Navigation block already does this, so there is a precedent in core blocks.

Similar arguments could be made for the Columns block, which recently got background and text color options as well.

@ZebulanStanphill ZebulanStanphill added [Type] Enhancement A suggestion for improvement. [Block] Columns Affects the Columns Block [Block] Group Affects the Group Block (and row, stack and grid variants) labels Feb 6, 2020
@paaljoachim
Copy link
Contributor

Thanks for bringing this up Zebulan!

@ZebulanStanphill ZebulanStanphill added the [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi label Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Columns Affects the Columns Block [Block] Group Affects the Group Block (and row, stack and grid variants) [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

2 participants