-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cover: Move color controls to the toolbar #20837
Comments
Related issue for Group and Columns blocks: #20070. |
👋 Halloo! I started looking into this today. Ma goodness! What a journey. It's definitely a challenge, especially if we want to do it cleanly. I'm up for taking this one! Just want to leave a note for my future self (and to others) Don't under estimate this one 🙃 |
Got a quick + dirty version working. (Ignore the One thing I noticed is that there may be cases where the dropdown menu will cover the content (like above). It's a little unsettling (at least for me). I prefer the controls being on the sidebar (as disconnected as they are). At least it allows me to see the Cover in full view as I adjust it. If anyone is curious, I pushed up my explorations here: Branch: |
@ItsJonQ I think this one should be present in both places. There some work left to do to clean the contents but this is a good first step to exposing the most important tools. |
@mtias Great! Thanks for your thoughts :). In that case, I'll proceed with this effort! |
@mtias I thought we wanted to avoid duplicate controls in the toolbar/inspector? |
Currently the color/gradient controls seem to be very tied to the inspector panels, and they are also in the middle of an update, so it may make sense to defer this until that work is finalised. I have added a comment over on the color component issue about this as it would be good to have the use of these components in inspector panels and dropdowns considered as part of that work. |
There is a very rudimentary PoC branch that adds the existing color panel to a dropdown just to see how it looks at https://github.com/WordPress/gutenberg/tree/move/cover-color-to-tool-menu |
Also slightly related: #34680 |
Color controls, like background media, are primary features of this block and should be moved to the toolbar:
The text was updated successfully, but these errors were encountered: