Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus not visible on Content Structure pane #15324

Closed
karlgroves opened this issue Apr 30, 2019 · 4 comments · Fixed by #15479
Closed

Focus not visible on Content Structure pane #15324

karlgroves opened this issue Apr 30, 2019 · 4 comments · Fixed by #15479
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).

Comments

@karlgroves
Copy link

Focus not visible on Content Structure pane

  • Severity: Medium
  • Affected Populations:
    • Low-Vision
    • Motor Impaired
    • Cognitively Impaired
  • Platform(s):
    • All / Universal
  • Components affected:
    • Structure and Navigation

Issue description

Keyboard users cannot see their focus position within the Content
Structure popover, when focus is on the popover itself, or on the
"Document Statistics" section within it.

All focused elements should have a visible and obvious focus indicator,
so that sighted keyboard users have a clear indication of which element
has focus.

Issue Code
    <div class="components-popover__content" tabindex="-1">


        <div class="table-of-contents__counts" role="note" aria-label="Document Statistics" tabindex="0">


            ...


        </div>


    </div>


    ...


    a, div {


        outline: 0;


    }

Remediation Guidance

Remove the CSS which negates the focus style on these elements, or
override it with specific focus styles on the applicable elements.

Recommended Code
    components-popover__content {


        /* some outline style */


    }

Relevant standards

Note: This issue may be a duplicate with other existing accessibility-related bugs in this project. This issue comes from the Gutenberg accessibility audit, performed by Tenon and funded by WP Campus. This issue is GUT-26 in Tenon's report

@gziolo gziolo added the Needs Accessibility Feedback Need input from accessibility label Apr 30, 2019
@melchoyce
Copy link
Contributor

Screenshot from full report:

image

@afercia
Copy link
Contributor

afercia commented May 5, 2019

At some point, there was a focus indication on the popover container, see:

Popover: Visually indicate focus effect on popover content
#3057

Looks like it's not working any longer or been removed? /Cc @aduth

@afercia afercia added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Technical Feedback Needs testing from a developer perspective. and removed Needs Accessibility Feedback Need input from accessibility labels May 5, 2019
@aduth
Copy link
Member

aduth commented May 6, 2019

By the git history of the component, it seems like it may have been removed around the time of 6517ee9 or 6f38bba / d3bd425 , which each seem to modify the specific style. But in the context of their respective pull requests #3400 and #3401, it's not clear whether or not if or for what purpose it was intended.

cc @youknowriad @jasmussen

jasmussen pushed a commit that referenced this issue May 7, 2019
This PR intends to, and maybe fixes #15324. That is, it restores the focus outline style to the document outline popover which regressed.
@jasmussen
Copy link
Contributor

I took a stab at a fix in #15479.

jasmussen pushed a commit that referenced this issue May 8, 2019
This PR intends to, and maybe fixes #15324. That is, it restores the focus outline style to the document outline popover which regressed.
@gziolo gziolo removed the Needs Technical Feedback Needs testing from a developer perspective. label May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants