fix: remove new query parameter when create new campaign #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajohn25
approved these changes
Nov 1, 2024
I've stripped out the isNew prop from the AdminCampaignEdit component as suggested. Let me know if this PR should be good to be merged in. |
Awesome go for it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the new=true query parameter from the URL when creating a new campaign, addressing unexpected navigation behavior in the campaign builder.
Motivation and Context
This change resolves the issue where the new=true query parameter forces admins back to the Basics tab upon saving another section, interrupting the intended flow when filling out sections in any order. See issue #56 for details.
How Has This Been Tested?
Tested by creating a new campaign, navigating between sections, and confirming no forced navigation back to the Basics tab after saving.
Additional Notes:
The AdminCampaignEdit component still retains the isNew prop, which is currently unused but related to the removed new=true query parameter.
Screenshots (if appropriate):
Documentation Changes
Checklist: