Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "new" query parameter from campaign builder #56

Closed
ajohn25 opened this issue Oct 8, 2024 · 0 comments · Fixed by #59
Closed

Remove "new" query parameter from campaign builder #56

ajohn25 opened this issue Oct 8, 2024 · 0 comments · Fixed by #59
Assignees
Labels
improvement: enhancement ✨ Improvement to existing functionality mindless: chore 🧹 Mindless chore platform: react ⚛️ Related to React client application

Comments

@ajohn25
Copy link
Collaborator

ajohn25 commented Oct 8, 2024

Describe the bug
When creating a new campaign (vs. copying from an existing one) Spoke automatically adds the query parameter new=true to the URL. This may control other Spoke behavior, but one of its effects is definitely to force navigation back to the Basics tab if the admin tries to fill in other sections of the campaign builder before the Basics tab. While this may have made sense at some point in Spoke's history, it doesn't accurately reflect how admins now interact with the campaign builder, where sections are often filled out out of order.

To Reproduce
Steps to reproduce the behavior:

  1. Click the Create a Campaign button on the campaigns page (/admin/1/campaigns)
  2. Click Create New Campaign
  3. Notice the URL has new=true appended as a query parameter
  4. Don't fill in the basics tab - navigate to a different section and make a change there instead
  5. Save that section
  6. Notice Spoke navigates back to the basics tab

Expected behavior
Don't force navigation back to the basics tab after saving another section.

Additional context
We can likely drop this query parameter entirely, but we should document any additional behavior that this query parameter controls to ensure it's safe to remove

@ajohn25 ajohn25 added mindless: chore 🧹 Mindless chore platform: react ⚛️ Related to React client application improvement: enhancement ✨ Improvement to existing functionality labels Oct 8, 2024
@ajohn25 ajohn25 linked a pull request Nov 18, 2024 that will close this issue
2 tasks
@ajohn25 ajohn25 closed this as completed Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement: enhancement ✨ Improvement to existing functionality mindless: chore 🧹 Mindless chore platform: react ⚛️ Related to React client application
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants