Support builds for Electron v31 #1200
Conversation
There was a problem hiding this comment.
Thanks for the PR, @neoxpert !
There are subtle differences in semantics for v8::Persistent and v8::Global, but I couldn't find a good authoritative explanation other than https://groups.google.com/g/v8-users/c/uSx4F8Uvwis -- but the instance cardinality discussion gave me the willies.
We could minimize impact if this macro was #if/#else ed to only change with the newest version of v8 in electron v31.
@JoshuaWise what do you think?
There was a problem hiding this comment.
Ah! The deprecation message said to use v8::Global instead of v8::CopyablePersistentTraits -- so let's trust that. I sent @JoshuaWise an email to review this PR (as my approval isn't sufficient to merge it).
|
v8::Global is not copyable; it has move semantics. This change should be fine, as we don't use the copy semantics anymore anyways. However, it's pretty misleading for the template to be called |
* replace v8::CopyablePersistentTraits with v8::Global * add Electron v31 to build tasks
* replace v8::CopyablePersistentTraits with v8::Global * add Electron v31 to build tasks
Replaced deprecated v8::CopyablePersistentTraits with v8::Global to enabled builds for Electron v31.