Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electron 31 support #93

Closed
reintjanhoiting1 opened this issue Jun 13, 2024 · 5 comments
Closed

Electron 31 support #93

reintjanhoiting1 opened this issue Jun 13, 2024 · 5 comments
Labels
authored-by-supporter ❤️ The author of this issue/PR is a project supporter fixed ✅

Comments

@reintjanhoiting1
Copy link

How can we get support for electron 31? since 31 is stable?

Here is an example in a different repo:
WiseLibs/better-sqlite3#1200

@m4heshd
Copy link
Owner

m4heshd commented Jun 13, 2024

@reintjanhoiting1 It's already merged (5f4d5c9) and being worked on. But there's a lot more going on with broken builds. You're going to have to compile the addon yourself for the moment.

@m4heshd m4heshd added work-in-progress ⚙️ This feature/issue is currently being worked on blocked-by-upstream 🛑 This issue is waiting for a fix on a depending library labels Jun 13, 2024
@reintjanhoiting1
Copy link
Author

@m4heshd , Thanks for the update!

@m4heshd
Copy link
Owner

m4heshd commented Jun 17, 2024

@reintjanhoiting1 Just realized you were the one who just sent the big donation my way. Thank you for your support. It really motivates me to put more time and effort into this addon.

@m4heshd m4heshd added the authored-by-supporter ❤️ The author of this issue/PR is a project supporter label Jun 17, 2024
@reintjanhoiting1
Copy link
Author

@m4heshd Thanks for your reaction and your support. I am glad you will put more time and effort into this add-on. You have more experience in this area than I do.

@m4heshd
Copy link
Owner

m4heshd commented Jul 1, 2024

Hi, this has been fixed in the latest release. Closing the issue. Feel free to reopen or add to the conversation if there are any issues. 😊

@m4heshd m4heshd closed this as completed Jul 1, 2024
@m4heshd m4heshd added fixed ✅ and removed work-in-progress ⚙️ This feature/issue is currently being worked on blocked-by-upstream 🛑 This issue is waiting for a fix on a depending library labels Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
authored-by-supporter ❤️ The author of this issue/PR is a project supporter fixed ✅
Projects
None yet
Development

No branches or pull requests

2 participants