Enable the use of PRAGMA Key to encrypt db #1018
Conversation
* Move repetitive build commands into environment variables * Merge 'https://github.com/mceachen/better-sqlite3/tree/dry-gha-989' Co-authored-by: mceachen <mceachen@users.noreply.github.com> --------- Co-authored-by: mceachen <mceachen@users.noreply.github.com>
* Move repetitive build commands into environment variables (#989) * Move repetitive build commands into environment variables * Merge 'https://github.com/mceachen/better-sqlite3/tree/dry-gha-989' Co-authored-by: mceachen <mceachen@users.noreply.github.com> --------- Co-authored-by: mceachen <mceachen@users.noreply.github.com> * restore "env." prefixes to NODE_BUILD_CMD and ELECTRON_BUILD_CMD --------- Co-authored-by: mceachen <mceachen@users.noreply.github.com> Co-authored-by: Matthew McEachen <matthew@photostructure.com>
* Add support for Node v20 prebuilds * Also test v20
Remove node.js v14 builds and testing (runtime EOL)
* Fix out-of-bounds read in statement tail parser * Add comment with link to tail parsing issue * Fix missing increment in tail parser + tests
Co-authored-by: mceachen <mceachen@users.noreply.github.com>
Prebuild for Node on other architectures as well
Run `ncu -u`
Fix buffer create in sandbox mode (electron)
Fix: Allow building with space in path
From the docs: > This option is obsolete. It used to enable some extra some extra > PRAGMA statements such as PRAGMA function_list, PRAGMA module_list, > and PRAGMA pragma_list, but those pragmas are now all enabled by > default. See SQLITE_OMIT_INTROSPECTION_PRAGMAS. It has been obsolete since 2019-10-04 (with SQLite 3.30.0).
* Added `webpack` support * changed from `webpack_require` to `non_webpack_require` * Update database.js Added URL to webpack documentation * feat(database): now `nativeBinding` supports addon object * style(package): line break removed --------- Co-authored-by: Matthew McEachen <matthew@photostructure.com>
added HAVE_USLEEP=1 compile-time option
* replace v8::CopyablePersistentTraits with v8::Global * add Electron v31 to build tasks
* use c++20 required by v8 * adjust macro and method signatures * replace SetAccessor with SetNativeDataProperty * use old signatures for older node version * install g++ 10 on ubuntu
added prebuild for electron 32.0.0
Co-authored-by: mceachen <mceachen@users.noreply.github.com>
|
Sorry for the dumb question, but I’m a bit confused reviewing the PR history. Is this something being actively worked on with a chance for merge? Or for an encrypted SQLite database do we need to use something like https://github.com/m4heshd/better-sqlite3-multiple-ciphers?tab=readme-ov-file ? thanks! |
|
Ok thanks @m4heshd ... I saw that but never saw a response from Josh so wasn't sure whether the conversation continued somewhere else. So is the plan that you keep that fork up to date with better SQLite 3 and just add the encryption extension to it? Or is it forked and will have other commits / changes to it? I really love better SQLite 3 and appreciate all the work and history here so want to make sure I am able to stick to the maintainability of this repo as I trust its future :) can you explain a little bit your plan for your repo? Is it basically to just keep the same as better SQLite 3 and just have a build version that allows encryption? Are there any differences? Thanks a ton!! |
feat: add support for electron 33
added NodeJS 23 to build and test matrix
Co-authored-by: mceachen <mceachen@users.noreply.github.com>
Personally, I think that a Sqlite database that has so many features and improvements but that has no way to make it secure seems to me to be of little use, even so, I will use it with the hope that one day it will be able to encrypt its data.