Change GTG checkout to submodule and remove manage_externals #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove manage_externals copy from repo - remove associated Externals.cfg file - replacing GTG checkout with submodules Refs: NOAA-EMC#363
- created .gitmodules file via git submodule add command: git submodule add https://github.com/NCAR/UPP_GTG sorc/post_gtg.fd - new post_gtg.fd subfolder added (empty before submodule checkout) Refs: NOAA-EMC#363
|
@KateFriedman-NOAA I tested on your branch for gtg code checking out as: It seems I can't use the https url for gtg checking out, but the ssh url is working. Do you know anything is missing on my github account? |
|
@WenMeng-NOAA GitHub deprecated the use of passwords in late summer and so users have to use personal access tokens now. This part of the error gives info on that: So you need to set up a personal access token in your GitHub account and add it to a new Generate a token, add it within a .git-credentials file in your /u/$USER area on Dogwood (and other HPCs), and then try that clone again. Let me know how it goes. With a personal access token in place it won't matter what method you use for cloning, it will use your token like a password and you'll have passwordless git actions (push/pull). |
|
@KateFriedman-NOAA Your tips work for me. Now I can clone gtg code. Thanks! |
WenMeng-NOAA
approved these changes
Dec 7, 2021
|
Glad it's working for you now @WenMeng-NOAA ! Thanks for approving this PR, please feel free to submit it into your branch now, I don't have a submit button to do it myself. |
|
@KateFriedman-NOAA I was able to checkout GTG code successfully and compiled the code without problems. The only issue is GTG repository. GTG is delivered by tags, and the operational one is https://github.com/NCAR/UPP_GTG/tree/ncep_post_gtg.v2.0.3. |
|
@KateFriedman-NOAA Please ignore the previous comments. @aerorahul has explained that submodule tracks the hash of the commit. |
WenMeng-NOAA
pushed a commit
that referenced
this pull request
Dec 13, 2021
* Turn on GSD cloud ceiling calculation for RRFS dev. * Updates to UPP for RRFS applications (#3) * Updates to UPP for RRFS applications: 1) Adding a RRFS-specific .xml control file and a corresponding .txt flat file. Note that script changes (pending) are needed to leverage the new flat file. However, this code will work in current real-time configurations. 2) Adding GSL experimental ceiling diagnostics, GSL visibility diagnostic, and GSL sea-level pressure reduction (MAPS). Also adding TKE and aerosol number concentrations. 3) Code clean-up for ceiling-related diagnostics; added comments, etc. 4) Removing several non-needed variables, originally inherited from FV3-SAR community configuration. * Updating UPP control files to specify GRIB2 generating center as "noaa_fsl_boulder" and the generating process as "hrrr". The "hrrr" specification is temporary, and will eventually be switched to "rrfs" once required changes to the "NCEPLIBS-g2tmpl" library are available. (#4) * Fix some out-of-bounds reads that caused the RRFS UPP to crash. (#5) * Adding README file (#7) * Adding README file to describe process of making a "flat" file. * Updates to README to improve explanation of input/output files. * Code to read in Flash Flood Guidance (FFG) and Average Recurrence Interval (ARI) precipitation datasets for comparison with model QPF within UPP. * Fixed a syntax error in SURFCE.f * Getting rid of GRIB1 output option to be consistent with rest of code. * Changing field numbers to avoid conflict with existing RRFS-dev1 fields. * Putting exceedance grids in flat files for testing in RRFS UPP. * Corrected the 1h and run total precip names for calculating exceedances in SURFCE.f * Bug fix in SURFCE.f if statements. * Removing changes to RQSTFLD.F since GRIB1 is no longer used in UPP. * Merging NOAA-GSL development on top of NOAA-EMC UPP for testing. * Correcting minor typos in SURFCE.f to allow testing. * Update code based on testing with RRFS cases. * Update part of the code based on current EMC develop branch for comparing the test results with the merged version.(#9) * Fixed several bugs in the code. * Modifications to SURFCE.f to check for existence of FFG files. * Bug fixes for FFG file existence check, and changes to handle rotated lat-lon grid interpolation for FFG * Bug fixes for FFG existence checks in SURFCE.f * Another bug fix for SURFCE.f * Updating XML and flat txt files to include a 65th vertical level to be consistent with updated FV3LAM model with higher model top. (NOAA-EMC#13) * Code cleanup for QPF - FFG comparison. Comparison put into subroutine. * Cleanup of SURFCE.f; moving the FFG comparisons into a subroutine. * Final cleanup of exceedance code for QPF vs FFG. * Removing some commented out variable declarations. * Additional cleanup recommended by Ming: we really only need two exceedance variables; one for 1h FFG and one for run total FFG exceedances. * Further cleanup of FFG code, simplifying to two fields (1h acc and run total acc) * Adding ARI comparison fields for 2y, 5y, 10y, and 100y ARIs. * Changes to output 9 soil levels from FV3LAM if we are running 9 level RUC LSM. * Adding flat txt file for UPP. * Commenting out the use of the ARI exceedances for now. We can switch them on later. * Bug fix in INITPOST_NETCDF.f : need to use both ncid2d and ncid3d in this subroutine! * Adding NOAA-GSL code changes on top of latest NOAA-EMC UPP. * Couple of bug fixes in NOAA-EMC code. Bugs were leading to PRMSL and -10C REFD being all zeroes. * Cleaning up code to get rid of unnecessary differences from EMC. * Putting all new GSL variables into EMC's unified post_avblflds.xml. Note that EMC's unified post_avblflds.xml does not validate using the avblflds Schema. * Updating postconfig-NT.txt file for GSL RRFS based on merged post_avblflds.xml file. * Adding RRFS control files to makefile. * Changing back scale for WEASD_ON_SURFACE to previous default, thanks to suggestion from Wen Meng. * Reverting name of cldfra based on feedback from Eric Aligo. * Reverting changes in fv3lam_post_avblflds.xml since GSL new variables are now included in post_avblflds.xml * Changing experimental ceiling level type from "ceiling" to "cloud_ceilng" * Updating 3drtma_postcntrl.xml with revised name for GSD_EXP_CEILING. This also affects postxconfig-NT-3drtma.txt. postxconfig-NT-fv3lam_rrfs.txt also changed due to changes in post_avblflds.xml * Introducing if statement for call of NGMSLP, to avoid calling unless it is needed. Co-authored-by: Ming.Hu <Ming.Hu@noaa.gov> Co-authored-by: Christina Holt <56881914+christinaholtNOAA@users.noreply.github.com> Co-authored-by: Christina Holt <Christina.Holt@noaa.gov> Co-authored-by: Jaymes Kenyon <jaymes.kenyon@noaa.gov> Co-authored-by: Samuel Trahan (NOAA contractor) <39415369+SamuelTrahanNOAA@users.noreply.github.com>
WenMeng-NOAA
added a commit
that referenced
this pull request
Jan 11, 2022
* Add changes for building executable on wcoss2. * Add changes for buding upp lib on wcoss2. * Add changes for building upp lib on wcoss2. * Update hdf5 and netcdf modules. * Upgrade manage_externals to new version which works for python 3.8.5. * Remove jlogfile in workflow scripts. * Changes for overriding module versions from upstream setting. * Changes for overriding module versions from upstream setting for building upp lib. * Update for POSTGRB2TBL default setting. * Update for LMod compliance. * Remove v8.0.0-wcoss2 and lib-wcoss2; correct typo in upp_wcoss2.lua and post_wcoss2.lua. * Remove jflofile per Kate's comments * Change GTG checkout to submodule and remove manage_externals (#5) * Retire manage_externals for GTG checkout - remove manage_externals copy from repo - remove associated Externals.cfg file - replacing GTG checkout with submodules Refs: NOAA-EMC#363 * Add UPP_GTG submodule - created .gitmodules file via git submodule add command: git submodule add https://github.com/NCAR/UPP_GTG sorc/post_gtg.fd - new post_gtg.fd subfolder added (empty before submodule checkout) Refs: NOAA-EMC#363 * Updating submodule pointer of GTG to ncep_post_gtg.v2.0.4 * Teak makefile_lib. Co-authored-by: Wen Meng <Wen.Meng@clogin02.cactus.wcoss2.ncep.noaa.gov> Co-authored-by: Kate Friedman <kate.friedman@noaa.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the following:
Associated updates are made on the workflow side to update the checkout process to use the submodule for GTG. Here is the build log for the UPP with GTG after testing the clone updates from my fork branch:
To test my updates in my fork branch:
If you do not use
--recursiveit will NOT invoke the submodule and will NOT clone the GTG.Refs: NOAA-EMC#420, NOAA-EMC#363