Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor #4

Merged
merged 8 commits into from
Aug 13, 2021
Merged

Refactor #4

merged 8 commits into from
Aug 13, 2021

Conversation

JesseMeng-NOAA
Copy link
Collaborator

No description provided.

aerorahul and others added 8 commits July 13, 2020 19:53
@aerorahul
build application with wrfio library (NOAA-EMC#148)
8802461 
* build application with wrfio library

Change-Id: I01537949ef59e839339d07f59faaedb9e14512f5

* rename wrfio -> wrf_io

Change-Id: I795959db4ba757a7765995a42041fc4ed3319081
@WenMeng-NOAA
Post ceilling (NOAA-EMC#136)
e8f0f2e 
* Add the changes of outputing ceiling height for global FV3.

* Output low,middle,high cloud fraction; radar reflectivity at model layer 1, 2; 1 and 4 km radar reflectivity.

* Add the bug fix of initializing DBZI from Ruiyu.

* 1)correct time averaged cloud fraction at low/mid/high cloud layer grib2 name from "TCDC" to "LCDC/MCDC/HCDC"; 2)output mixed layer CAPE/CIN; 3)remove simulated GOES-12 brightness temperature.

* Clean up v8.0.0-hera.
@WenMeng-NOAA
1)Add changes of total cloud fraction for FV3 GFS; 2)Tweak DBZI. (NOA…
8f2e0d9 
…A-EMC#142)
@YaliMao-NOAA @WenMeng-NOAA
UPP WAFS update (NOAA-EMC#111)
a25f6ab 
* 1. UPP WAFS outputs on ICAO standard levels with the exact number
2. sorc/ncep_post.fd/MDLFLD.f changes interface to call gtg_algo()
3. scripts/exgfs_nceppost.sh.ecf, UPP WAFS outputs hourly when forecast is between 6 to 12, every 3 hours other than that.

* Relabel ICAO pressure level from the exact number to reference number.

* WAFS data will be generated hourly when forecast hour <= 24

* 1. Add CB base, top, extent to CLDRAD.f, post_avblflds.xml and postcntrl_gfs_wafs.xml
2. Add GTG output on hybrid levels to MDLFLD.f and post_avblflds.xml

Co-authored-by: Yali Mao <ymao@Orion-login-3.HPC.MsState.Edu>
@WenMeng-NOAA
Set 1 mb upper bound for searching EQ level in CAPE computation from …
41ed232 
…Hui-ya. (NOAA-EMC#149)
@WenMeng-NOAA
Add the wafs fix from Yali. (NOAA-EMC#150)
427fa51
@DusanJovic-NOAA
Fix bug in MDL2STD_P.f. Use ampersand as line continuation character (N…
47cc562 
…OAA-EMC#153)
@aerorahul
update pointer to CMakeModules (NOAA-EMC#156)
688c425
@WenMeng-NOAA
Copy link
Owner

Can you submit your PR to the branch develop at https://github.com/NOAA-EMC/EMC_post instead of my fork? Thanks!

@JesseMeng-NOAA
Copy link
Collaborator Author

JesseMeng-NOAA commented Aug 13, 2020 via email

@WenMeng-NOAA
Copy link
Owner

I saw your fork is a sub-fork of my UPP fork. You might delete your fork and re-create from the original UPP repos.

@WenMeng-NOAA WenMeng-NOAA merged commit 688c425 into WenMeng-NOAA:develop Aug 13, 2021
WenMeng-NOAA pushed a commit that referenced this pull request Dec 13, 2021
@EricJames-NOAA @hu5970
@christinaholtNOAA @jaymes-kenyon @SamuelTrahanNOAA
NOAA GSL UPP updates (NOAA-EMC#413)
0dc3c0c 
* Turn on GSD cloud ceiling calculation for RRFS dev.

* Updates to UPP for RRFS applications (#3)

* Updates to UPP for RRFS applications:
1) Adding a RRFS-specific .xml control file and a corresponding .txt flat file.  Note that script changes (pending) are needed to leverage the new flat file.  However, this code will work in current real-time configurations.
2) Adding GSL experimental ceiling diagnostics, GSL visibility diagnostic, and GSL sea-level pressure reduction (MAPS).  Also adding TKE and aerosol number concentrations.
3) Code clean-up for ceiling-related diagnostics; added comments, etc.
4) Removing several non-needed variables, originally inherited from FV3-SAR community configuration.

* Updating UPP control files to specify GRIB2 generating center as "noaa_fsl_boulder" and the generating process as "hrrr".  The "hrrr" specification is temporary, and will eventually be switched to "rrfs" once required changes to the "NCEPLIBS-g2tmpl" library are available. (#4)

* Fix some out-of-bounds reads that caused the RRFS UPP to crash. (#5)

* Adding README file (#7)

* Adding README file to describe process of making a "flat" file.

* Updates to README to improve explanation of input/output files.

* Code to read in Flash Flood Guidance (FFG) and Average Recurrence Interval (ARI) precipitation datasets for comparison with model QPF within UPP.

* Fixed a syntax error in SURFCE.f

* Getting rid of GRIB1 output option to be consistent with rest of code.

* Changing field numbers to avoid conflict with existing RRFS-dev1 fields.

* Putting exceedance grids in flat files for testing in RRFS UPP.

* Corrected the 1h and run total precip names for calculating exceedances in SURFCE.f

* Bug fix in SURFCE.f if statements.

* Removing changes to RQSTFLD.F since GRIB1 is no longer used in UPP.

* Merging NOAA-GSL development on top of NOAA-EMC UPP for testing.

* Correcting minor typos in SURFCE.f to allow testing.

* Update code based on testing with RRFS cases.

* Update part of the code based on current EMC develop branch for comparing the test results with the merged version.(#9)

* Fixed several bugs in the code.

* Modifications to SURFCE.f to check for existence of FFG files.

* Bug fixes for FFG file existence check, and changes to handle rotated lat-lon grid interpolation for FFG

* Bug fixes for FFG existence checks in SURFCE.f

* Another bug fix for SURFCE.f

* Updating XML and flat txt files to include a 65th vertical level to be consistent with updated FV3LAM model with higher model top. (NOAA-EMC#13)

* Code cleanup for QPF - FFG comparison.  Comparison put into subroutine.

* Cleanup of SURFCE.f; moving the FFG comparisons into a subroutine.

* Final cleanup of exceedance code for QPF vs FFG.

* Removing some commented out variable declarations.

* Additional cleanup recommended by Ming: we really only need two exceedance variables; one for 1h FFG and one for run total FFG exceedances.

* Further cleanup of FFG code, simplifying to two fields (1h acc and run total acc)

* Adding ARI comparison fields for 2y, 5y, 10y, and 100y ARIs.

* Changes to output 9 soil levels from FV3LAM if we are running 9 level RUC LSM.

* Adding flat txt file for UPP.

* Commenting out the use of the ARI exceedances for now.  We can switch them on later.

* Bug fix in INITPOST_NETCDF.f : need to use both ncid2d and ncid3d in this subroutine!

* Adding NOAA-GSL code changes on top of latest NOAA-EMC UPP.

* Couple of bug fixes in NOAA-EMC code.  Bugs were leading to PRMSL and -10C REFD being all zeroes.

* Cleaning up code to get rid of unnecessary differences from EMC.

* Putting all new GSL variables into EMC's unified post_avblflds.xml.  Note that EMC's unified post_avblflds.xml does not validate using the avblflds Schema.

* Updating postconfig-NT.txt file for GSL RRFS based on merged post_avblflds.xml file.

* Adding RRFS control files to makefile.

* Changing back scale for WEASD_ON_SURFACE to previous default, thanks to suggestion from Wen Meng.

* Reverting name of cldfra based on feedback from Eric Aligo.

* Reverting changes in fv3lam_post_avblflds.xml since GSL new variables are now included in post_avblflds.xml

* Changing experimental ceiling level type from "ceiling" to "cloud_ceilng"

* Updating 3drtma_postcntrl.xml with revised name for GSD_EXP_CEILING.  This also affects postxconfig-NT-3drtma.txt.  postxconfig-NT-fv3lam_rrfs.txt also changed due to changes in post_avblflds.xml

* Introducing if statement for call of NGMSLP, to avoid calling unless it is needed.

Co-authored-by: Ming.Hu <Ming.Hu@noaa.gov>
Co-authored-by: Christina Holt <56881914+christinaholtNOAA@users.noreply.github.com>
Co-authored-by: Christina Holt <Christina.Holt@noaa.gov>
Co-authored-by: Jaymes Kenyon <jaymes.kenyon@noaa.gov>
Co-authored-by: Samuel Trahan (NOAA contractor) <39415369+SamuelTrahanNOAA@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JesseMeng-NOAA @WenMeng-NOAA @aerorahul @YaliMao-NOAA @DusanJovic-NOAA