Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Cleanup, reorganise folder structure. #117

Merged
merged 8 commits into from
Jul 20, 2017
Merged

WIP Cleanup, reorganise folder structure. #117

merged 8 commits into from
Jul 20, 2017

Conversation

Treora
Copy link
Collaborator

@Treora Treora commented Jul 12, 2017

Addressing #112 (it's a code emergency! :)).

/extension is to be a build output folder. Folder structure in /src
should match that of the output, so that e.g. a <script> tag's src
reference can be followed (except the jsx is renamed to js).
Make css names implicit, allowing both css-modules and plain css files.
No more optimistic messages telling "Finished 'build' after 23 ms".
Sequential tasks in gulp <=3 is a hassle, so adding this to package.json.
Cost >5 minutes to save 0.1MB; not worth it.
@Treora Treora merged commit ae47597 into master Jul 20, 2017
@Treora Treora deleted the cleanup branch July 20, 2017 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant