-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up file/folder organisation #112
Comments
Could put them in sub dirs of the main module's dir, like HTML files could be treated as static files in the same way, or could unify them in a shared template and spit them out for their respective build tasks using something like |
Thanks still for the input. For now the question about images is solved, since there are no images anymore (using semantic-ui's icons and ditched the background). The question will probably pop up again though. I started cleaning up in the 'cleanup' branch, checking at least some of the boxes. |
Various changes to improve the source organisation and build process. Makes ./extension an output-only folder; cleaned up before every build. Plenty of intended improvements are not yet addressed; see issue #112.
This one has been done in 124319d. The other tasks may have to wait a bit; upcoming feature developments may give a better picture of the logical grouping. I suspect the aspects of logging visits and storing pages should be more clearly separated. |
Lots of reorganisation done in #135. It could always be better, but it seems good enough to close this. |
The organisation of this repo has become a bit messy over time. I intend to move some things around soon, currently thinking about these changes:
overview
,,options
page-viewer
), what is background or content script, and what is commonly usable by any of them. Be more consistent in using (or possibly remove) the separation ofbackground
andcontent_script
folders, it is a bit confusing now.extension
, intosrc
. Rename bundled scripts (e.g.src/overview/main.jsx
) so they match the names used in html script tags (also hard-wire output naming in gulp task).extension
is to be more like a 'build
' output folder. (where do we put images?)src/overview
, separate 'application' (main.jsx
+store.js
) and 'redux module' (the rest). Maybe make 'application' part reusable for e.g. options page.src/search/find-pages
intosrc/page-storage
, it's not really search-related.activity-logger
,page-analysis
,page-storage
, andsearch
, or at least define their roles and interfaces better.generateVisitDocId
functions etc in some sensible way.src/browser-history
, ...more?src/freeze-dry
into its own repo (or else intoutil
).The text was updated successfully, but these errors were encountered: