Add a section on sourceMappingURL #151
Conversation
|
(strangely, I don't even have rights to pick reviewers, so cc @dschuff @yurydelendik @kripken) |
|
I think the reviewer thing is just because you're apparently not a member of the WebAssembly Github group. I just sent you an invitation. |
Debugging.md
Outdated
| # Source maps | ||
|
|
||
| Adoption of DWARF is a fairly recent addition to WebAssembly, and many toolchains still | ||
| support an earlier [Source Map based debugging proposal](https://github.com/WebAssembly/design/pull/1051). |
There was a problem hiding this comment.
Since that PR might or might not ever make it into the wasm web spec, maybe we should just copy the relevant bits of it here, so that someone reading this wouldn't have to go read that and figure out what's relevant .That PR is really more of a design doc than a spec (it is a PR against the design repo after all). I think this PR currently has the info from "Linking generated code to source maps", so maybe just copy the info from "Locations"?
There was a problem hiding this comment.
I was hesitant to go too deep into details in this doc, just like we don't explain specifics of DWARF here, but only link to external resources, but if it's just the "locations" info, then yeah, it seems reasonably short to include...
There was a problem hiding this comment.
Merged the Locations explanation into this description.
Interesting, I suppose I was only a member / co-owner on specific repos. Thanks for the invite! |
Co-authored-by: Derek Schuff <dschuff@chromium.org>
|
@dschuff Looks like I don't have merge rights, can you squash & merge please? |
A follow-up to #149. See #148.