Add Debugging.md #149
Merged
Add Debugging.md #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RReverser
approved these changes
Oct 23, 2020
yurydelendik
approved these changes
Oct 23, 2020
dschuff
reviewed
Oct 29, 2020
| | path_name_str | `bytes` | Path to debug info file | | ||
|
|
||
| `path_name` is the location of a file containing DWARF debug info. Note that it | ||
| may also contain the full wasm file as well, which can be simpler to handle |
There was a problem hiding this comment.
it might be a little clearer to say that the file with the debug info is a wasm container, and that it might also contain the wasm code.
| | Field | Type | Description | | ||
| | ------------- | ----------- | ---------------------------------- | | ||
| | path_name_len | `varuint32` | Length of `path_name_str` in bytes | | ||
| | path_name_str | `bytes` | Path to debug info file | |
There was a problem hiding this comment.
should we specify that this is a relative path (and relative to what?)
There was a problem hiding this comment.
It doesn't have to be relative (I think). Although, instead of path maybe it would be better to say url here to make that clearer.
Looks like those should be easy enough to fixup in a follow-up PR? |
kripken
added a commit
that referenced
this pull request
Oct 30, 2020
dschuff
pushed a commit
that referenced
this pull request
Oct 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #148