Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deprecate web3wallet #5467

Merged
merged 4 commits into from
Oct 31, 2024
Merged

chore: deprecate web3wallet #5467

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dbbf8b8
chore: deprecate web3wallet
ganchoradkov Oct 30, 2024
c9262c6
chore: adds repo link
ganchoradkov Oct 30, 2024
8171c4a
fix: ci
ganchoradkov Oct 30, 2024
98ee542
Merge branch 'chore/deprecate-web3wallet' of github.com:WalletConnect…
ganchoradkov Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@
"packages/utils",
"packages/core",
"packages/sign-client",
"packages/react-native-compat",
"packages/web3wallet",
"packages/react-native-compat",
"providers/universal-provider",
"providers/signer-connection",
"providers/ethereum-provider"
Expand All @@ -37,7 +37,7 @@
"test:ignoreUnhandled": "npm run test:ignoreUnhandled --workspaces --if-present",
"check": "npm run lint; npm run build; npm run test",
"reset": "npm run clean; npm run check",
"new-version": "lerna version --no-private --no-git-tag-version --exact && ./scripts/update_relayer_sdk_version.sh && ./scripts/update_web3wallet_version.sh && npm i",
"new-version": "lerna version --no-private --no-git-tag-version --exact && ./scripts/update_relayer_sdk_version.sh",
"pre-publish": "npm run new-version; npm run reset",
"npm-publish:rc": "lerna exec --no-private -- npm publish --access public --tag rc",
"npm-publish:latest": "lerna exec --no-private -- npm publish --access public --tag latest",
Expand Down
4 changes: 4 additions & 0 deletions packages/web3wallet/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# Deprecation Warning ⚠️⚠️⚠️

Web3Wallet package is deprecated. Please use [`@reown/walletkit`](https://github.com/reown-com/reown-walletkit-js) instead. [Migration guide link](https://docs.reown.com/walletkit/upgrade/from-web3wallet-web)

# @walletconnect/web3wallet

## Description
Expand Down
2 changes: 1 addition & 1 deletion packages/web3wallet/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "@walletconnect/web3wallet",
"description": "Web3Wallet for WalletConnect Protocol",
"version": "1.16.1",
"private": false,
"private": true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this hide the package in npm?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, just prevents publishing. We'll leave it for now in case a security patch has to be published

"author": "WalletConnect, Inc. <walletconnect.com>",
"homepage": "https://github.com/walletconnect/walletconnect-monorepo/",
"license": "Apache-2.0",
Expand Down
33 changes: 0 additions & 33 deletions scripts/update_web3wallet_version.sh
View file
Open in desktop

This file was deleted.

Loading