Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deprecate web3wallet #5467

Merged
merged 4 commits into from
Oct 31, 2024
Merged

chore: deprecate web3wallet #5467

merged 4 commits into from
Oct 31, 2024

Conversation

ganchoradkov
Copy link
Member

Description

Web3Wallet package is deprecated in favour of @reown/walletkit

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Draft PR (breaking/non-breaking change which needs more work for having a proper functionality [Mark this PR as ready to review only when completely ready])
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How has this been tested?

n/a

Checklist

  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Additional Information (Optional)

Please include any additional information that may be useful for the reviewer.

@arein arein added the accepted label Oct 30, 2024
@@ -2,7 +2,7 @@
"name": "@walletconnect/web3wallet",
"description": "Web3Wallet for WalletConnect Protocol",
"version": "1.16.1",
"private": false,
"private": true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this hide the package in npm?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, just prevents publishing. We'll leave it for now in case a security patch has to be published

@ganchoradkov ganchoradkov merged commit f0bb9af into v2.0 Oct 31, 2024
9 checks passed
@ganchoradkov ganchoradkov deleted the chore/deprecate-web3wallet branch October 31, 2024 12:36
@ganchoradkov ganchoradkov mentioned this pull request Nov 5, 2024
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants