Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Promises to guard only the high-entropy bits #48

Merged
merged 2 commits into from
Jan 27, 2020
Merged

Move Promises to guard only the high-entropy bits #48

merged 2 commits into from
Jan 27, 2020

Conversation

yoavweiss
Copy link
Collaborator

Closes #39

chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Jan 27, 2020
@chromium-wpt-export-bot
[UA client hints] Align implementation with PR#46 and PR#48
0e1f939 
This CL aligns the UA-CH implementation with PR#46[1] and 48[2].
It also turns a bunch of the high entropy attributes into methods, in
preparation for upcoming changes that will turn them into promises.

[1] WICG/ua-client-hints#46
[2] WICG/ua-client-hints#48

Change-Id: I8221d8a967213180a1aa1d9ef23f17e6f95718b7
@chromium-wpt-export-bot chromium-wpt-export-bot mentioned this pull request Jan 27, 2020
Merged
@yoavweiss yoavweiss mentioned this pull request Jan 27, 2020
Closed
@yoavweiss
Copy link
Collaborator Author

@foolip - Could you review this and let me know if the IDL is somehow horribly wrong?

This was referenced Jan 27, 2020
Closed
Closed
amtunlimited
amtunlimited approved these changes Jan 27, 2020
View reviewed changes
Copy link
Contributor

@amtunlimited amtunlimited left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yoavweiss yoavweiss merged commit db666d6 into WICG:master Jan 27, 2020
@yoavweiss yoavweiss deleted the promises branch January 27, 2020 13:52
@yoavweiss
Copy link
Collaborator Author

@domenic - landing, but I'd still appreciate a review of the IDL

chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Jan 27, 2020
@chromium-wpt-export-bot
[UA client hints] Align implementation with PR#46 and PR#48
ba16c7b 
This CL aligns the UA-CH implementation with PR#46[1] and 48[2].
It also turns a bunch of the high entropy attributes into methods, in
preparation for upcoming changes that will turn them into promises.

[1] WICG/ua-client-hints#46
[2] WICG/ua-client-hints#48

Change-Id: I8221d8a967213180a1aa1d9ef23f17e6f95718b7
@domenic domenic mentioned this pull request Jan 27, 2020
Closed
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Mar 3, 2020
@chromium-wpt-export-bot
[UA client hints] Align implementation with PR#46 and PR#48
882198d 
This CL aligns the UA-CH implementation with PR#46[1] and 48[2].
It also turns a bunch of the high entropy attributes into methods, in
preparation for upcoming changes that will turn them into promises.

[1] WICG/ua-client-hints#46
[2] WICG/ua-client-hints#48

Change-Id: I8221d8a967213180a1aa1d9ef23f17e6f95718b7
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Mar 3, 2020
@chromium-wpt-export-bot
[UA client hints] Align implementation with PR#46, #48 & #70
b14db07 
This CL aligns the UA-CH implementation with PR#46[1], #48[2] and
#70[3].

[1] WICG/ua-client-hints#46
[2] WICG/ua-client-hints#48
[3] WICG/ua-client-hints#70

Change-Id: I8221d8a967213180a1aa1d9ef23f17e6f95718b7
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Mar 3, 2020
@chromium-wpt-export-bot
[UA client hints] Align implementation with PR#46, #48 & #70
7eb7f6d 
This CL aligns the UA-CH implementation with PR#46[1], #48[2] and
#70[3].

[1] WICG/ua-client-hints#46
[2] WICG/ua-client-hints#48
[3] WICG/ua-client-hints#70

Change-Id: I8221d8a967213180a1aa1d9ef23f17e6f95718b7
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Mar 3, 2020
@chromium-wpt-export-bot
[UA client hints] Align implementation with PR#46, #48 & #70
95304f9 
This CL aligns the UA-CH implementation with PR#46[1], #48[2] and
#70[3].

[1] WICG/ua-client-hints#46
[2] WICG/ua-client-hints#48
[3] WICG/ua-client-hints#70

Change-Id: I8221d8a967213180a1aa1d9ef23f17e6f95718b7
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Mar 3, 2020
@chromium-wpt-export-bot
[UA client hints] Align implementation with PR#46, #48 & #70
7ecac8e 
This CL aligns the UA-CH implementation with PR#46[1], #48[2] and
#70[3].

[1] WICG/ua-client-hints#46
[2] WICG/ua-client-hints#48
[3] WICG/ua-client-hints#70

Change-Id: I8221d8a967213180a1aa1d9ef23f17e6f95718b7
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Mar 4, 2020
@chromium-wpt-export-bot
[UA client hints] Align implementation with PR#46, #48 & #70
f8f785d 
This CL aligns the UA-CH implementation with PR#46[1], #48[2] and
#70[3].

[1] WICG/ua-client-hints#46
[2] WICG/ua-client-hints#48
[3] WICG/ua-client-hints#70

Change-Id: I8221d8a967213180a1aa1d9ef23f17e6f95718b7
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Mar 4, 2020
@chromium-wpt-export-bot
[UA client hints] Align implementation with PR#46, #48 & #70
2be175d 
This CL aligns the UA-CH implementation with PR#46[1], #48[2] and
#70[3].

[1] WICG/ua-client-hints#46
[2] WICG/ua-client-hints#48
[3] WICG/ua-client-hints#70

Change-Id: I8221d8a967213180a1aa1d9ef23f17e6f95718b7
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Mar 5, 2020
@chromium-wpt-export-bot
[UA client hints] Align implementation with PR#46, #48 & #70
547d6aa 
This CL aligns the UA-CH implementation with PR#46[1], #48[2] and
#70[3].

[1] WICG/ua-client-hints#46
[2] WICG/ua-client-hints#48
[3] WICG/ua-client-hints#70

Change-Id: I8221d8a967213180a1aa1d9ef23f17e6f95718b7
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Mar 6, 2020
@chromium-wpt-export-bot
[UA client hints] Align implementation with PR#46, #48 & #70
071e0fe 
This CL aligns the UA-CH implementation with PR#46[1], #48[2] and
#70[3].

[1] WICG/ua-client-hints#46
[2] WICG/ua-client-hints#48
[3] WICG/ua-client-hints#70

Change-Id: I8221d8a967213180a1aa1d9ef23f17e6f95718b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019369
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
Reviewed-by: Aaron Tagliaboschi <aarontag@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Yoav Weiss <yoavweiss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747644}
pull bot pushed a commit to FreddyZeng/chromium that referenced this pull request Mar 6, 2020
[UA client hints] Align implementation with PR#46, #48 & #70
1aeefa8 
This CL aligns the UA-CH implementation with PR#46[1], #48[2] and
#70[3].


[1] WICG/ua-client-hints#46
[2] WICG/ua-client-hints#48
[3] WICG/ua-client-hints#70

Change-Id: I8221d8a967213180a1aa1d9ef23f17e6f95718b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019369
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
Reviewed-by: Aaron Tagliaboschi <aarontag@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Yoav Weiss <yoavweiss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747644}
Hexcles pushed a commit to web-platform-tests/wpt that referenced this pull request Mar 6, 2020
@Hexcles
[UA client hints] Align implementation with PR#46, #48 & #70
e0be414 
This CL aligns the UA-CH implementation with PR#46[1], #48[2] and
#70[3].

[1] WICG/ua-client-hints#46
[2] WICG/ua-client-hints#48
[3] WICG/ua-client-hints#70

Change-Id: I8221d8a967213180a1aa1d9ef23f17e6f95718b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019369
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
Reviewed-by: Aaron Tagliaboschi <aarontag@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Yoav Weiss <yoavweiss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747644}
xeonchen pushed a commit to xeonchen/gecko that referenced this pull request Mar 11, 2020
@moz-wptsync-bot
Bug 1611717 [wpt PR 21428] - [UA client hints] Align implementation w…
bcd7e3a 
…ith PR#46, #48 & #70, a=testonly

Automatic update from web-platform-tests
[UA client hints] Align implementation with PR#46, #48 & #70

This CL aligns the UA-CH implementation with PR#46[1], #48[2] and
#70[3].

[1] WICG/ua-client-hints#46
[2] WICG/ua-client-hints#48
[3] WICG/ua-client-hints#70

Change-Id: I8221d8a967213180a1aa1d9ef23f17e6f95718b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019369
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
Reviewed-by: Aaron Tagliaboschi <aarontag@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Yoav Weiss <yoavweiss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747644}

--

wpt-commits: e0be414fa1d9f3b4e841ca74bfc43ee3d7586fc4
wpt-pr: 21428
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Mar 12, 2020
@moz-wptsync-bot
Bug 1611717 [wpt PR 21428] - [UA client hints] Align implementation w…
fbe15a1 
…ith PR#46, #48 & #70, a=testonly

Automatic update from web-platform-tests
[UA client hints] Align implementation with PR#46, #48 & #70

This CL aligns the UA-CH implementation with PR#46[1], #48[2] and
#70[3].

[1] WICG/ua-client-hints#46
[2] WICG/ua-client-hints#48
[3] WICG/ua-client-hints#70

Change-Id: I8221d8a967213180a1aa1d9ef23f17e6f95718b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019369
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
Reviewed-by: Aaron Tagliaboschi <aarontag@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Yoav Weiss <yoavweiss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747644}

--

wpt-commits: e0be414fa1d9f3b4e841ca74bfc43ee3d7586fc4
wpt-pr: 21428
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Mar 12, 2020
@marco-c
Bug 1611717 [wpt PR 21428] - [UA client hints] Align implementation w…
0419bc1 
…ith PR#46, #48 & #70, a=testonly

Automatic update from web-platform-tests
[UA client hints] Align implementation with PR#46, #48 & #70

This CL aligns the UA-CH implementation with PR#46[1], #48[2] and
#70[3].

[1] WICG/ua-client-hints#46
[2] WICG/ua-client-hints#48
[3] WICG/ua-client-hints#70

Change-Id: I8221d8a967213180a1aa1d9ef23f17e6f95718b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019369
Reviewed-by: Mike West <mkwstchromium.org>
Reviewed-by: Daniel Vogelheim <vogelheimchromium.org>
Reviewed-by: Aaron Tagliaboschi <aarontagchromium.org>
Reviewed-by: Avi Drissman <avichromium.org>
Commit-Queue: Yoav Weiss <yoavweisschromium.org>
Cr-Commit-Position: refs/heads/master{#747644}

--

wpt-commits: e0be414fa1d9f3b4e841ca74bfc43ee3d7586fc4
wpt-pr: 21428

UltraBlame original commit: 222962fe639e45b4d3f8f769e49446edf4133207
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Mar 12, 2020
@marco-c
Bug 1611717 [wpt PR 21428] - [UA client hints] Align implementation w…
323a60c 
…ith PR#46, #48 & #70, a=testonly

Automatic update from web-platform-tests
[UA client hints] Align implementation with PR#46, #48 & #70

This CL aligns the UA-CH implementation with PR#46[1], #48[2] and
#70[3].

[1] WICG/ua-client-hints#46
[2] WICG/ua-client-hints#48
[3] WICG/ua-client-hints#70

Change-Id: I8221d8a967213180a1aa1d9ef23f17e6f95718b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019369
Reviewed-by: Mike West <mkwstchromium.org>
Reviewed-by: Daniel Vogelheim <vogelheimchromium.org>
Reviewed-by: Aaron Tagliaboschi <aarontagchromium.org>
Reviewed-by: Avi Drissman <avichromium.org>
Commit-Queue: Yoav Weiss <yoavweisschromium.org>
Cr-Commit-Position: refs/heads/master{#747644}

--

wpt-commits: e0be414fa1d9f3b4e841ca74bfc43ee3d7586fc4
wpt-pr: 21428

UltraBlame original commit: 222962fe639e45b4d3f8f769e49446edf4133207
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Mar 12, 2020
@marco-c
Bug 1611717 [wpt PR 21428] - [UA client hints] Align implementation w…
ba04bd0 
…ith PR#46, #48 & #70, a=testonly

Automatic update from web-platform-tests
[UA client hints] Align implementation with PR#46, #48 & #70

This CL aligns the UA-CH implementation with PR#46[1], #48[2] and
#70[3].

[1] WICG/ua-client-hints#46
[2] WICG/ua-client-hints#48
[3] WICG/ua-client-hints#70

Change-Id: I8221d8a967213180a1aa1d9ef23f17e6f95718b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019369
Reviewed-by: Mike West <mkwstchromium.org>
Reviewed-by: Daniel Vogelheim <vogelheimchromium.org>
Reviewed-by: Aaron Tagliaboschi <aarontagchromium.org>
Reviewed-by: Avi Drissman <avichromium.org>
Commit-Queue: Yoav Weiss <yoavweisschromium.org>
Cr-Commit-Position: refs/heads/master{#747644}

--

wpt-commits: e0be414fa1d9f3b4e841ca74bfc43ee3d7586fc4
wpt-pr: 21428

UltraBlame original commit: 222962fe639e45b4d3f8f769e49446edf4133207
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amtunlimited amtunlimited amtunlimited approved these changes

@domenic domenic Awaiting requested review from domenic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Single promise for getUserAgent?
2 participants
@yoavweiss @amtunlimited