[pull] master from chromium:master #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Bug: 1045506 Change-Id: I3e8b192331c848241848e754ffde0309b620efcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022669 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Auto-Submit: Rayan Kanso <rayankans@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#735432}
Change-Id: I09c9a01620d2c9667e1a80c68a367952b10b6042 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020926 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#735433}
Bug: 936425 Change-Id: Iff33d59b71980d040825f0d78860dd121e77b120 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020922 Auto-Submit: kylechar <kylechar@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#735434}
Chromium uses the 10.14 SDK, so remove any code that handles the case of an old SDK being used. Bug: 1044838 Change-Id: I5db561bfaf5b8e6aac7352dac010d90fb202bdf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020883 Auto-Submit: Avi Drissman <avi@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#735435}
…icy_helper.cc" This reverts commit a6198a9. Sort keys of python dictionary so that deterministic build won't fail. Original change's description: > Revert "Refactoring origin trial dependency generation in feature_policy_helper.cc" > > This reverts commit 0c31aad. > > Reason for revert: Somewhat speculative; looks like it made > the build nondeterministic (https://crbug.com/1038775) > > Original change's description: > > Refactoring origin trial dependency generation in feature_policy_helper.cc > > > > This CL refactors build script code that generates feature_policy_helper.cc, > > so that the logic could be reused for document policy. > > > > - Simplifies make_runtime_features_utilities.py API. > > - Makes most util functions pure. > > - Adds more unittests > > > > The output of make_feature_policy_helper is verified to be the same as before. > > > > Bug: 993790 > > Change-Id: I0f0e07888f5b9e02727e3f210bbfb4cd871ecc15 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003255 > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 993790 > Change-Id: If7aaa4c6b851f74db6b418b480cf8482b15cf7b1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013472 Bug: 993790 Change-Id: I4100bfed3c14da388d625df39f93d428497f1671 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016339 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#735436}
Spec: https://drafts.csswg.org/web-animations-1/#remove-replaced-animations Intent: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/H5sz_dg6fKc/1X7K7U4XCgAJ Bug: 981905 Change-Id: I9267e3e4fda14133f2edcc0e8aea1e8a031959a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020245 Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#735437}
TBR=jlebel@chromium.org Bug: 1045478 Change-Id: I531d38944da8c6c5b57d6d7e94b217ab8a303b28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022928 Reviewed-by: François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#735438}
https://skia.googlesource.com/skia.git/+log/2c5b856a7f09..b1e9971eb712 git log 2c5b856a7f09..b1e9971eb712 --date=short --first-parent --format='%ad %ae %s' 2020-01-27 brianosman@google.com Switch runtime SkSL to always sample at explicit coords 2020-01-27 sergeyu@google.com Fix GrSmallPathRenderer to respect max texture size. 2020-01-27 kjlubick@google.com [canvaskit] Fix test for drawOnce Created with: gclient setdep -r src/third_party/skia@b1e9971eb712 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: reed@google.com Change-Id: Ic888343ead714d0dca80f0a603993d6d7293f4f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022967 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735439}
…a login. Bug: 1045536 Change-Id: Idd58ba1153e1e006bc07c54305db39e217e91779 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020243 Auto-Submit: Rakesh Soma <rakeshsoma@google.com> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Tien Mai <tienmai@chromium.org> Commit-Queue: Rakesh Soma <rakeshsoma@google.com> Cr-Commit-Position: refs/heads/master@{#735440}
Using wpt-import in Chromium c06f226. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: binji@chromium.org: external/wpt/wasm chcunningham@chromium.org, wolenetz@chromium.org: external/wpt/media-source domenic@chromium.org, ricea@chromium.org: external/wpt/streams futhark@chromium.org, andruud@chromium.org, ericwilligers@chromium.org, shend@chromium.org: external/wpt/css/css-conditional hbos@chromium.org, hta@chromium.org: external/wpt/webrtc jsbell@chromium.org: external/wpt/IndexedDB external/wpt/encoding jsbell@chromium.org, mek@chromium.org: external/wpt/FileAPI mcasas@chromium.org: external/wpt/mediacapture-record meade@chromium.org: external/wpt/web-animations mek@chromium.org: external/wpt/webmessaging mkwst@chromium.org: external/wpt/trusted-types mkwst@chromium.org, andypaicu@chromium.org: external/wpt/content-security-policy nzolghadr@chromium.org, mustaq@chromium.org: external/wpt/pointerevents raphael.kubo.da.costa@intel.com, rijubrata.bhaumik@intel.com, timvolodine@chromium.org: external/wpt/generic-sensor yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I829df5abb577665adafb08dbeb61ffda3f40e78f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022325 Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735441}
In this CL, I did a cleanup: https://chromium-review.googlesource.com/c/chromium/src/+/1937773 But the cleanup had a negative side effect, in that repreated presses of Ctrl+E for entering keyword mode would cause the omnibox popup to close and re-open. This CL is a partial revert of the original CL, but keeps the flag deletion portion. It also makes sure a TODO that was wrong is gone. Bug: 1044917 Change-Id: Idceb8c73d4a5907cfca8966bf41f80c09fc130bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020473 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#735442}
…5ca20 (10 commits) $ git log 34381dd16..e5005ca20 --date=short --no-merges --format='%ad %ae %s' 2020-01-24 featherless Bump the release. 2020-01-24 featherless Notes. 2020-01-16 rsmoore [Chips] Fix `imagePadding` behavior. (#9442) 2020-01-16 rsmoore [Chips] Additional `imagePadding` tests. (#9441) 2020-01-16 rsmoore [Chips] Fix `contentPadding` API. (#9440) 2020-01-16 featherless [AppBar] Annotate MDCAppBarNavigationControllerDelegate's appBarNavigationController:willAddAppBar:asChildOfViewController: as to be deprecated. (#9395) 2020-01-21 featherless Automatic changelog preparation for release. 2020-01-17 featherless Revert "merged release-candidate" 2020-01-17 andrewoverton [TextControls] Restructure Cocoapods and Blaze targets (#9430) 2020-01-16 codyleeweaver [TextFields] Add theming extension for underline controller (#9437) Created with: roll-dep src/ios/third_party/material_components_ios/src Notable fixes: manually updated the list of files to build as part of the framework as some files were added/renamed/removed. Bug: 1045877 Change-Id: I2d4ab61b4ab67161f99baa3907ea3bb499d9867a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022947 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#735443}
Adds a field to Thread::Options to allow the task queue time domain to be configured, to enable Thread users to test task posting functionality using synthetic time. Bug: 1034758 Change-Id: I9b301f98e856a86045a12bab6e25569d4ef9b330 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020480 Reviewed-by: Gabriel Charette <gab@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#735444}
Those are needed when compiling against SDKs older than 10.12 or so, but Chromium has compiled against the 10.14 SDK for a while. Bug: 1044838 Change-Id: Id9a70aa1c702b0c1992963c1fbd0a2e26f8e07ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020805 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#735445}
The following tests are being disabled on iphone-device: BookmarksTestCase/testMoveDoesSaveOnSave BookmarksTestCase/testEmptyBackgroundAndSelectButton BookmarksTestCase/testBookmarkContextBarInMultipleSelectionModes BookmarksTestCase/testBookmarkContextBarInSingleSelectionModes BookmarksTestCase/testKeyboardCommandsNotRegistered_EditBookmark BookmarksEntriesTestCase/testContextMenuForMixedSelection TBR= sczs@chromium.org Bug: 1045966 Change-Id: Idd767cc19e7443825be6f08680813732426770ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020932 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#735446}
I am switching everything to my Google account. Change-Id: I68ac60c7243d8520a98c929a636d3ccb32d086f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022254 Commit-Queue: Leon Scroggins <scroggo@chromium.org> Commit-Queue: Mike Klein <mtklein@google.com> Auto-Submit: Leon Scroggins <scroggo@chromium.org> Reviewed-by: Mike Klein <mtklein@google.com> Cr-Commit-Position: refs/heads/master@{#735447}
https://webrtc.googlesource.com/src.git/+log/ff0e4dbd1f0b..8c79c6e1af35 git log ff0e4dbd1f0b..8c79c6e1af35 --date=short --first-parent --format='%ad %ae %s' 2020-01-27 srte@webrtc.org Only include overhead if using send side bandwidth estimation. 2020-01-27 hbos@webrtc.org [Overuse] Move GetCpuOveruseOptions() to adaption module. Created with: gclient setdep -r src/third_party/webrtc@8c79c6e1af35 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I878d1f84a19f160d4e7125b2cffb6e2b85d2accf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022966 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735448}
…hemes" This reverts commit 6e293fe. Reason for revert: Some of the new tests are flaky Original change's description: > OOR-CORS, WebView: Add CORS tests for requests from custom schemes > > Behaviors have been unclear, but if requests are made from a custom > scheme, the Origin header in outgoing requests should be set to > "<scheme>://" without containing the host:port part those are > officially required to be a proper origin for such special cases > in WebView. > Servers can use "Access-Control-Allow-Origin: *" or > "Access-Control-Allow-Origin: <scheme>://" to permit such accesses. > > This patch adds tests to verify these behaviors to keep compatible > behaviors. > > Bug: 1035366 > Change-Id: Ia08e7b4ed764225566c3b09edef2980cfa1b1b70 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010591 > Reviewed-by: Richard Coles <torne@chromium.org> > Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> > Cr-Commit-Position: refs/heads/master@{#735332} TBR=toyoshim@chromium.org,torne@chromium.org Change-Id: Ib494a7fc40f6eec0b2c92dd35046b191751931e2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1035366 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023046 Reviewed-by: Patrick Noland <pnoland@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#735449}
Rebaseline of web tests in custom-elements, editing, and fast directories. Bug: 1028242 Change-Id: Idab238ce374bb3fa01bdc0ac8535f74afe090ac1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022351 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Auto-Submit: John Chen <johnchen@chromium.org> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#735450}
TBR=pdr@chromium.org Bug: 524134 Change-Id: Ic612a760cb4ec7ed951b5026e1e0a81d7966a466 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022255 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#735451}
resource_timing_buffer_full_eventually.html is still flaky. Adding all the flaky combinations in the flake portal after 'fix' landed. TBR=ksakamoto@chromium.org Bug: 989665 Change-Id: I58caec5484fb6dfd5162c50d3819f78f14838f3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020895 Reviewed-by: Nicolás Peña Moreno <npm@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#735452}
Change-Id: I37c2578a6b36e0de25a889bf636e122b7d8987f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022253 Reviewed-by: Daniel Rubery <drubery@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#735453}
TBR=govind@chromium.org Change-Id: I07fd1dff3c8af9244c867387c4322ddf9370d472 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021301 Reviewed-by: Ben Mason <benmason@chromium.org> Reviewed-by: Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#735454}
…rofile in release" The original patch moved a CHECK behind an #ifdef NDEBUG in an attempt to ease debugging. According to crbug.com/496653#c73, it was supposed to be reverted, but that never happened. We shouldn't keep shipping a CHECK to users that's disabled in Debug builds, so this revert drops the ifdef again to turn on the CHECK everywhere. Original review: https://codereview.chromium.org/1591543002 Bug: chromium:496653, chromium:1040839 Change-Id: I71a743b6355a0072ed5ae5281f79a2d948da9adb R: mfoltz@chromium.org, avi@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022791 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#735455}
Fixes few glitches with switching the drag image widget when rip off
drag status changes with scrollable shelf (the drag image is switched
between one owned by shelf_view and one owned by the shelf view's drag
and drop host):
* disables the shelf view's drag image proxy visibility animations
(so the icon disappears immediately, instead of fading out while the
new drag image keeps moving)
* when the icon is dragged back to shelf, and the drag image is
replaced with the drag and drop icon, do not update the drag_view_
location - given that HandleRipOffDrag returns false in this case,
the drag_view_ bounds will be updated after HandleRipOffDrag (doing
it twice misplaces the created drag image, at least until the next
drag update is handled).
* Make drag image position relative to the cursor consistent between
two proxies - scrollable shelf view's proxy keeps the cursor
position from the drag start, while shelf view's proxy was centering
the cursor.
BUG=1042533
Change-Id: If9fa5cea3a8714a22c6b58a75af5cf2fe08efc70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021612
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735456}
I've confirmed that the uploads are coming through. Bug: 1024318 Change-Id: I69015590c02cbbe722ab9e91a90574aa76d7f356 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022621 Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#735457}
Test testSignOutAndClearDataFromNonManagedAccountClearsData is being disabled. TBR=jlebel@chromium.com Bug: 1045981 Change-Id: I6682e5f78e2203d73045c3c17cfddaba93dd4c08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022653 Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#735458}
This also moves ScopedRevocationReporter into PermissionUmaUtil, since it seems to make more sense there and will be a bit more complicated to move to the component. Bug: 1025609 Change-Id: Ic98cabaec50e35a3292e3a4310223cf2cbfaca5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020750 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#735459}
These tests fail when the BlockHTMLParserOnStyleSheet flag is turned on. The reason is that, with this flag, there is no way to block rendering. Fragment anchors currently defer some behavior while rendering is blocked. When the flag ships, this will no longer be possible. However, the behavior being checked by some of these tests can still occur, just in a different order. This CL fixes these tests so that they continue to guard the intended behavior. This generally means that the fragment will now invoke but we test the behavior between this initial invocation and a subsequent one by delaying the document load event. Bug: 891767 Change-Id: I0564b1f487c48be2f5efbb1c6478e3375a71e518 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020503 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#735460}
9df6272 Move buffer and buffer_pos down (#125) 43c6826 Fix strtod.cc undefined constants (#123) 1dce44c Add full license to test .cc files missing it. (#121) 8857767 Add wasm32 as supported platform (#120) a54561b Pseiderer/add nios2 and xtensa 001 (#119) 5cc233e Add support for microblaze. 4a51e73 Add support for e2k architecture. (#118) 7da5db9 Add min exponent width option in double-to-string conversion (#116) Bug: 977230 Change-Id: I89fbe9295172df16ae2668b750aeac6293e7b361 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023865 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> Cr-Commit-Position: refs/heads/master@{#735656}
CHROMEOS macro is defined in third_party/webrtc. This CL replaces it with more appropriate macro. Bug: None Change-Id: I38fd9e830b8d4b9a6585f7b554377e364daf50e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022024 Reviewed-by: Owen Min <zmin@chromium.org> Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Cr-Commit-Position: refs/heads/master@{#735657}
CHROMEOS macro is defined in third_party/webrtc. This CL replaces it with more appropriate macro. Bug: None Change-Id: I7c5c5928424c026b1fb679814617c1134c0d5537 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022584 Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Cr-Commit-Position: refs/heads/master@{#735658}
CL:1549297 adds scrolling to the top level menus hanging off a menu button. The calculation for limiting the height of the menu allowed the menu to sit inside the viewport with a large number of pixels gap resulting in a scroll-bar and scrollable region when the menu could fit inside the viewport without scrolling. Changes the calculation of positioning the top level menu so that more vertical space is used - limiting the height to 2 pixels less than the viewport. The 2 pixel gap at the bottom of the menu serves as a visual indicator for the user so they can see the menu ends there, rather than it appearing to be clipped. Bug: 1040058 Tests: browser_tests --gtest_filter="FileManagerJsTest.MultiMenu" Change-Id: Idb7d1199095d5d5e7482cc5b8eaa228439202bf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018364 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#735659}
CHROMEOS macro is defined in third_party/webrtc. This CL replaces it with more appropriate macro. Bug: None Change-Id: Ia62a2a1e4b129f7aef7aadb2e7d8158ff06b22f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022045 Reviewed-by: David Trainor <dtrainor@chromium.org> Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Cr-Commit-Position: refs/heads/master@{#735660}
in the context menu. This CL also adds four new histograms: ContextMenu.SelectedOptionAndroid.ImageLink.PerformanceClassFast ContextMenu.SelectedOptionAndroid.Link.PerformanceClassFast ContextMenu.TimeToTakeAction.Abandoned.PerformanceClassFast ContextMenu.TimeToTakeAction.SelectedItem.PerformanceClassFast These in tandem enable measuring how context menu usage is impacted by the presence of link performance information. Bug: 1030813 Change-Id: Ib65f8b410b12cb5442fa9afbd31f8e09d3af8616 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007941 Commit-Queue: Josh Simmons <jds@google.com> Reviewed-by: David Trainor <dtrainor@chromium.org> Reviewed-by: Tarun Bansal <tbansal@chromium.org> Reviewed-by: Megan Jablonski <megjablon@chromium.org> Cr-Commit-Position: refs/heads/master@{#735661}
Many places were including the extra methods when they only needed AppId, and it was potentially confusing that AppId is provided by web_app_helpers. Admittedly not our biggest problem, but a very easy fix that makes life better for future readers of the codebase. :) Mostly just a straight find/replace of includes when methods defined in web_app_helpers were not present. A few (mostly test) files had to have a new include of web_app_helpers because methods were previously pulled in through transitive includes. Change-Id: Ia19c13365733868c50ab3b9ec5affdb114aa5eb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016818 Reviewed-by: Alexey Baskakov <loyso@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#735662}
The PerformanceManagerTabHelper reflects WebContents and their frame trees into the PerformanceManager graph. This CL gives the graph visibility for the ChromeOS login's view. Bug: 993029 Change-Id: Ie1822ba72f64df9d29084e7bf2c42526273f86e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017928 Auto-Submit: Patrick Monette <pmonette@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#735663}
Chromium switched over to using HarfBuzz as the font subsetter. Bug: chromium:931719 Change-Id: If2efe982a6c29c193d2e298bb5dcb276bb481f5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716256 Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#735664}
This allows us to use the property expantion function in non-VM ARC code paths. BUG=b:144199481 TEST=try, no real code change Change-Id: Iab5a1b8bb6a3ed8d8dbf9d4c7fe598356b47f593 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024149 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#735665}
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3c0615232489..fbc74b472299 Created with: gclient setdep -r src-internal@fbc74b472299 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1040871,chromium:1045888,chromium:927262 Tbr: jbudorick@google.com Change-Id: I8f03bbe21761094b1942261b079643a6a6d88151 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023235 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735666}
https://chromium.googlesource.com/angle/angle.git/+log/a1f1cce6054f..2d1d9d35216b git log a1f1cce6054f..2d1d9d35216b --date=short --first-parent --format='%ad %ae %s' 2020-01-27 syoussefi@chromium.org Fix atomicAdd validation w.r.t to swizzles 2020-01-27 jonahr@google.com Expose eglGetMscRateCHROMIUM from EGL_CHROMIUM_sync_control Created with: gclient setdep -r src/third_party/angle@2d1d9d35216b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1042393 Tbr: tobine@google.com Change-Id: I12a7b40a4b2b317c04e9d3539ff359bc8244ff60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023222 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735667}
TBR: sullivan@chromium.org Bug: 1041709 Change-Id: Ie993df88a7ab5261659b9f1e04236cbb24df5a61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024121 Reviewed-by: Joe Downing <joedow@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#735668}
Need to make sure we add it as observer after fully initializing notification_icons_container_ Change-Id: Icd511f3dfdaac653899ddd9a09f64c62bd459ab4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023853 Reviewed-by: Tim Song <tengs@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#735669}
In crrev.com/c/1911065 we introduced a ground-truth metric for zero state files appearing in the UI, that was useful but costly to compute. We should take this out before M80 rolls out to stable. This CL deletes the function that computes the metric, to make the change we need to merge back into the M80 branch as small as possible. The rest of the infrastructure for the metric will be deleted in a follow-up CL. Bug: 1011221 Change-Id: I88a610a30347ade7d1a7fdfe3db341adb629b076 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016813 Reviewed-by: Jenny Zhang <jennyz@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#735670}
This URL Loader streams the response from memory. It isn't wired up to anything, so it isn't testable yet but is meaty enough to be its own CL. This is based on Offline Page's URL Loader. Bug: 1023483 Change-Id: I04ca25488942f9e901c157f9af4cc921fa7fa3a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018065 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#735671}
This is a preliminary change to share the implementation across multiple Chromium content embedders. Bug: 1042501 Change-Id: I398c0810de589529a0037875a30ad33c2f65aa50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013725 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by: Yuri Wiitala <miu@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#735672}
Now, dynamic SharedPrefs keys can also be grandfathered, so they don't need to be exhaustively listed anymore. Bug: 1022108 Change-Id: I8432ac41aed64b0e1f6dbee8ed556d32fe66a862 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011284 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#735673}
* Fuchsia uses a different crash report system (crashpad), so remove crash_reporter_client dependencies on fuchsia builds. R=afelch@google.com, kmackay@chromium.org Change-Id: I823148bf97d3b930d7ad984e071effc9c61affc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024035 Reviewed-by: Kenneth MacKay <kmackay@chromium.org> Reviewed-by: Yuchen Liu <yucliu@chromium.org> Commit-Queue: JinJie Chen <jinjiechen@google.com> Cr-Commit-Position: refs/heads/master@{#735674}
Bug: 1021634 Change-Id: I790546c8a78c25cb20a312d50c0c9f45797534cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018255 Commit-Queue: benjamin joyce <bjoyce@google.com> Reviewed-by: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#735675}
This changes the behavior of autotestPrivate.setTabletModeEnabled; it will ensure entering into the specified mode, and will not end and will not be affected by peripherals. As is described in the bug, it is crucial to ensure into a certain mode for conducting an integration test or a performance test, but sometimes the test scenarios or existence of peripherals can affect the intermediate states, which may cause failures when combined with multiple tests. This CL simplifies this situation by adding a new method to ash::TabletMode. Note that we can't change the behavior of existing SetEnabledForTest, because it is widely used by unittests and browsertests. Bug: 1040292 Test: tast run ui.ScreenRotationPerf ui.WindowResizePerf on scarlet Change-Id: I343e2b86c145bae789629df1baaf503fa2dfdef5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016193 Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by: Toni Baržić <tbarzic@chromium.org> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#735676}
The Chrome WebAuthn team has decided not to ship support for BLE authenticators in Web Authentication due to reliability issues. This CL removes the flag that allows it to be enabled. BLE authenticators can still be used with Chrome running on versions of Windows 10 that support the Hello API since that does not depend on this flag or Chrome's implementation. BUG=1046131 Change-Id: I2992fec02b95677d84a0b4fc65a5432a325e6c23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023671 Commit-Queue: Ken Buchanan <kenrb@chromium.org> Reviewed-by: Martin Kreichgauer <martinkr@google.com> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#735677}
Bug: 1015156 Change-Id: Iac379910bc94f003f5911134309c99d92b58cffe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023364 Reviewed-by: Saman Sami <samans@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#735678}
Update the multi-device setup service function SetHostDevice() and related functions to accept either a device's Instance ID or legacy RemoteDevice ID. The former is only present for devices using v2 DeviceSync and the latter is the encoded public key--given by RemoteDevice::GetDeviceId(). The legacy device ID will not be available from the v2 DeviceSync service until device metadata can be decrypted. This delay could prevent multi-device setup, especially during OOBE, unless SetHostDevice() also supports use of the Instance ID. By design, the Chrome OS CryptAuth client code guarantees that while v1 DeviceSync is running--whether in parallel with v2 DeviceSync or alone-- every device will always have an unencrypted legacy device ID, though some may not have an Instance ID. When v1 DeviceSync is turned off, however, only an Instance ID is guaranteed, and this CL is necessary. This CL is meant to be temporary. When v1 DeviceSync is turned off and no rollback is expected, the changes in this CL should be revised to only use Instance IDs since those are always guaranteed to exist in v2 DeviceSync. Variable name changes from |host_device_id| to the elegant |host_instance_id_or_legacy_device_id| comprise the bulk of this CL. The crucial logic changes are in start_setup_page.html/js and multidevice_setup_impl.cc. Bug: 951969, 1019206 Change-Id: I99c3b79cbb8414da65ee7b95dab80f661f15b13b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000972 Reviewed-by: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#735679}
In this change, we are continuing the work from CL 1992009 and setting up the ability for UKM Service to call into the ClonedInstallDetector to understand its state on construction and if it should reset the UKM client id. Bug: 981407 Change-Id: I5a330807bb938e2f2fe6f6e9fe5e8edb5b02432e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018242 Commit-Queue: Joshua Berenhaus <joshber@microsoft.com> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Joshua Berenhaus <joshber@microsoft.com> Cr-Commit-Position: refs/heads/master@{#735680}
There are no more used since: https://chromium-review.googlesource.com/c/chromium/src/+/2000640 Only: content/common/content_security_policy/csp_context.h needs to stay. It contains the definition of CSPViolationParams, which is still a native struct (for now). See UnifyCSP: https://docs.google.com/document/d/1v5mJnXJ5dSVXE_rgvJnNM9bzH0ni0YzdhPQ7GLqyhao Bug: 1021462 Change-Id: I7227fd6b9a75ac24b5e7c60c93c2f0c48dfa6464 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022673 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#735681}
pull bot
pushed a commit
that referenced
this pull request
Mar 6, 2020
This CL aligns the UA-CH implementation with PR#46[1], #48[2] and #70[3]. [1] WICG/ua-client-hints#46 [2] WICG/ua-client-hints#48 [3] WICG/ua-client-hints#70 Change-Id: I8221d8a967213180a1aa1d9ef23f17e6f95718b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019369 Reviewed-by: Mike West <mkwst@chromium.org> Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by: Aaron Tagliaboschi <aarontag@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#747644}
pull bot
pushed a commit
that referenced
this pull request
Mar 7, 2020
Using wpt-import in Chromium 2bd9927. With Chromium commits locally applied on WPT: d5cd6b9 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" acf3302 "Add testing for the scrolling attribute" 1aeefa8 "[UA client hints] Align implementation with PR#46, #48 & #70" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: I25ff300c5b0d4950eb1b2b20d3c9ab286a25e6e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089410 Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747919}
pull bot
pushed a commit
that referenced
this pull request
Apr 7, 2021
Roll src/ios/third_party/motion_transitioning_objc/src/ 5bb0d577d..1fe4a9d81 (6 commits) https://chromium.googlesource.com/external/github.com/material-motion/motion-transitioning-objc.git/+log/5bb0d577dd78..1fe4a9d81433 $ git log 5bb0d577d..1fe4a9d81 --date=short --no-merges --format='%ad %ae %s' 2021-04-06 featherless Update changelog. 2021-04-06 featherless Update changelog. 2021-04-06 featherless Bump the version. 2021-04-06 featherless Drop support for iOS 10. (#71) 2021-04-05 featherless Upgrade to Swift 5 and min OS of iOS 10. (#70) 2021-04-05 featherless Remove bazel support. (#69) Created with: roll-dep src/ios/third_party/motion_transitioning_objc/src Roll src/ios/third_party/motion_animator_objc/src/ 7710eca75..296f52932 (6 commits) https://chromium.googlesource.com/external/github.com/material-motion/motion-animator-objc.git/+log/7710eca756ee..296f529321dd $ git log 7710eca75..296f52932 --date=short --no-merges --format='%ad %ae %s' 2021-04-05 featherless Bump the release. 2021-04-05 featherless Update changelog. 2021-04-05 featherless Upgrade Pod dependencies and Swift version to 5.0 (#131) 2021-04-05 featherless Upgrade to Swift 5 and min OS of iOS 10. (#130) 2021-04-05 featherless Remove bazel support. (#129) 2021-03-04 featherless Fix a bug on iOS 14 causing flickers in MDC's ActivityIndicator (#127) Created with: roll-dep src/ios/third_party/motion_animator_objc/src Change-Id: I129042cb472258a7f3f3fe57df2e80cc59d75547 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2808975 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Olivier Robin <olivierrobin@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#869958}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]. Want to support this open source service? Please star it : )