Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redo integrity verification in IsolatedContext spec #44

Merged
merged 4 commits into from
Aug 10, 2024

Conversation

robbiemc
Copy link
Collaborator

@robbiemc robbiemc commented Jul 26, 2024

This addresses the issues raised by @domfarolino in #42 regarding how the spec was tying integrity verification to browsing context group. Rather than attaching integrity verification information to browsing context group, which doesn't exist for all environments, this moves the information to a user agent level map.


Preview | Diff

@robbiemc
Copy link
Collaborator Author

@domfarolino, could you review this as well?

isolated-contexts.bs Outdated Show resolved Hide resolved
Copy link

@domfarolino domfarolino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM % two questions. The first question is in the review. My second question is: by what mechanism does the origin integrity verification map get populated? Is the expectation just that browsers bake in their own static list of algorithms? If so, I think making that a "note" below the dfn would be good, since nothing currently defines how it gets populated (besides saying something about "implementation defined")

isolated-contexts.bs Outdated Show resolved Hide resolved
isolated-contexts.bs Outdated Show resolved Hide resolved
@robbiemc
Copy link
Collaborator Author

Generally LGTM % two questions. The first question is in the review. My second question is: by what mechanism does the origin integrity verification map get populated? Is the expectation just that browsers bake in their own static list of algorithms? If so, I think making that a "note" below the dfn would be good, since nothing currently defines how it gets populated (besides saying something about "implementation defined")

I added a note. This particular spec is focused on the security requirements needed to enable powerful capabilities, but is narrower than the entire IWA project, which is one implementation that satisfies the security requirements outlined here. Browser developers could in theory implement a system similar to Meta's Code Verify to meet these security requirements as well.

@robbiemc robbiemc merged commit ee2fccb into WICG:main Aug 10, 2024
2 checks passed
github-actions bot added a commit that referenced this pull request Aug 10, 2024
SHA: ee2fccb
Reason: push, by robbiemc

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit to robbiemc/isolated-web-apps that referenced this pull request Aug 10, 2024
SHA: ee2fccb
Reason: push, by robbiemc

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
robbiemc added a commit to robbiemc/isolated-web-apps that referenced this pull request Aug 10, 2024
This addresses the issues raised by @domfarolino in WICG#42 regarding how the spec was tying integrity verification to browsing context group. Rather than attaching integrity verification information to browsing context group, which doesn't exist for all environments, this moves the information to a user agent level map.
@robbiemc robbiemc deleted the integrity-redo branch August 10, 2024 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants