Incorporate most IsolatedContext review feedback #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@domfarolino, can you PTAL as well? |
reillyeon
requested changes
Jul 25, 2024
reillyeon
approved these changes
Jul 25, 2024
domfarolino
reviewed
Jul 26, 2024
|
I'm going to go ahead and land this and #44 to avoid merge conflicts with other changes. @domfarolino, I'm happy to continue working on this when you're back from vacation. |
github-actions bot
added a commit
that referenced
this pull request
Aug 10, 2024
SHA: 643417d Reason: push, by robbiemc Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
robbiemc
added a commit
to robbiemc/isolated-web-apps
that referenced
this pull request
Aug 10, 2024
This incorporates most of @domfarolino's feedback from issue WICG#42. It doesn't address the biggest issue about going from environment settings object to browsing context group, which will be in another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This incorporates most of @domfarolino's feedback from issue #42. It doesn't address the biggest issue about going from environment settings object to browsing context group, which will be in another PR.
Preview | Diff