Improve the export command messages
#978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gedochao
force-pushed
the
958-improve-export-output
branch
from
89607fe
to
24ec0bb
Compare
- fail early with a more descriptive message when the output path exists - fail early if an export to multiple build tools is requested - print the output path if the export is successful - print a relevant information early if the export is successfully started (in case it loads too long)
Gedochao
force-pushed
the
958-improve-export-output
branch
from
24ec0bb
to
520de16
Compare
lwronski
approved these changes
May 5, 2022
- add explicit types where relevant - remove unnecessary passing of default params
Gedochao
force-pushed
the
958-improve-export-output
branch
from
520de16
to
2982e7f
Compare
alexarchambault
approved these changes
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #958
Partially addresses #957 by adding some extra messages when the
exportcommand is executed