NIT Refactor Export

- add explicit types where relevant - remove unnecessary passing of default params
VirtusLab · May 5, 2022 · 89607fe · 89607fe
1 parent a205615
commit 89607fe
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/modules/cli/src/main/scala/scala/cli/commands/Export.scala b/modules/cli/src/main/scala/scala/cli/commands/Export.scala
@@ -46,9 +46,9 @@ object Export extends ScalaCommand[ExportOptions] {
   }
 
   // FIXME Auto-update those
-  def sbtBuildTool(extraSettings: Seq[String], sbtVersion: String, logger: Logger) =
+  def sbtBuildTool(extraSettings: Seq[String], sbtVersion: String, logger: Logger): Sbt =
     Sbt(sbtVersion, extraSettings, logger)
-  def millBuildTool(cache: FileCache[Task], logger: Logger) = {
+  def millBuildTool(cache: FileCache[Task], logger: Logger): Mill = {
     val launcherArtifacts = Seq(
       os.rel / "mill" -> s"https://github.com/lefou/millw/raw/${Constants.lefouMillwRef}/millw",
       os.rel / "mill.bat" -> s"https://github.com/lefou/millw/raw/${Constants.lefouMillwRef}/millw.bat"
@@ -97,9 +97,8 @@ object Export extends ScalaCommand[ExportOptions] {
     val inputs = options.shared.inputsOrExit(args)
     CurrentParams.workspaceOpt = Some(inputs.workspace)
     val baseOptions =
-      options.shared.buildOptions(enableJmh = false, None, ignoreErrors = false).copy(
-        mainClass = options.mainClass.mainClass.filter(_.nonEmpty)
-      )
+      options.shared.buildOptions(enableJmh = false, None)
+        .copy(mainClass = options.mainClass.mainClass.filter(_.nonEmpty))
 
     val (sourcesMain, optionsMain0) =
       prepareBuild(inputs, baseOptions, logger, options.shared.logging.verbosity, Scope.Main)