Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream sync on 8/13/2019 #70

Merged
merged 423 commits into from
Aug 15, 2019
Merged

Upstream sync on 8/13/2019 #70

merged 423 commits into from
Aug 15, 2019

Conversation

JunyiYi
Copy link
Collaborator

@JunyiYi JunyiYi commented Aug 14, 2019

No description provided.

tombuildsstuff and others added 30 commits July 17, 2019 13:22
…containers

r/storage_containers: switching to use the new SDK / support for `metadata`
Add metadata to azurerm_policy_definition example usage
…table-acl

Improvement: `azurerm_storage_table` ACL Support
…cord

New resource: azurerm_private_dns_zone_a_record
Co-Authored-By: Matthew Frahry <mbfrahry@gmail.com>
tombuildsstuff and others added 26 commits August 9, 2019 10:23
…logging_LogAnalyticsDestinationType

azurerm_monitor_diagnostic_setting - added LogAnalyticsDestinationType
The import example for the subscription filter is incorrect- the resource type is 'azurerm_servicebus_subscription', where it should be 'azurerm_servicebus_subscription_rule'
I noticed at the top of the page, it still said azurerm_dns_a_record …
…egs_hopefully_last

provider: yet one more set of client registration changes
* Update function_app.html.markdown

I have run into hours of headaches with Azure in particular -- unless some default app settings are specified / seeded within my terraform code. Please include note specified under app settings (and/or something similar). We deploy with Azure DevOps release pipeline, and without these defaults, we cannot successfully deploy to a terraformed function app.

* Update function_app.html.markdown
@JunyiYi JunyiYi changed the title Upstream sync Upstream sync on 8/13/2019 Aug 14, 2019
Copy link
Collaborator

@WodansSon WodansSon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@metacpp metacpp merged commit 2ab6a7d into master Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.