-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provider: yet one more set of client registration changes #4050
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of minor enhancements we can fix in a follow up PR but this otherwise LGTM 👍
PartnerId string | ||
SubscriptionId string | ||
TenantID string | ||
PartnerId string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not a blocker for this PR, but we should make these all Id
or ID
VMExtensionClient compute.VirtualMachineExtensionsClient | ||
VMScaleSetClient compute.VirtualMachineScaleSetsClient | ||
VMClient compute.VirtualMachinesClient | ||
VMImageClient compute.VirtualMachineImagesClient |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in a subsequent PR (since this affects everything) in retrospect all of the clients here should be pointers; so that we're forced to initialize these (which ensures the authorizer is added, which in turn helps provider developers debug issues)
This has been released in version 1.33.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 1.33.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
No description provided.