Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Electronのmain processで直接動作するコード以外からelectronに関する型を排除する #1278

Merged
merged 8 commits into from
Apr 5, 2023
Merged

Electronのmain processで直接動作するコード以外からelectronに関する型を排除する #1278

merged 8 commits into from
Apr 5, 2023

Commits on Apr 4, 2023

  1. onReceivedIPCMsg の event や戻り値を使用していないため、frontendからelectronの型を減らすべく関連す… 

    …る型を削除
    @yamachu
    yamachu committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    15b558b View commit details
    Browse the repository at this point in the history

  2. themeの型もelectronの型をベースに列挙する

    @yamachu
    yamachu committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    3ffb9ef View commit details
    Browse the repository at this point in the history

  3. MessageBoxもelectron依存の型なので、排除 

    MessageBoxも実際はどのボタンを押されたかのindexだけ欲しいはずなので、定義したinterfaceはもう少し小さくても良い
    @yamachu
    yamachu committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    13e9b4f View commit details
    Browse the repository at this point in the history

  4. shims-vue.d.tsはvueの知識だけを持つのが妥当そうなので、globalの方にSandboxの型定義を移す

    @yamachu
    yamachu committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    578d926 View commit details
    Browse the repository at this point in the history

  5. window.electron の electronがどこから来ているのかを明示するために、同じ定数を使用する

    @yamachu
    yamachu committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    2eecb72 View commit details
    Browse the repository at this point in the history

  6. lintで縛る

    @yamachu
    yamachu committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    85c4721 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2023

  1. Update .eslintrc.js 

    Co-authored-by: Hiroshiba <hihokaruta@gmail.com>
    @yamachu @Hiroshiba
    yamachu and Hiroshiba committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    aa58299 View commit details
    Browse the repository at this point in the history

  2. suggestを反映 

    VOICEVOX#1278 (comment)
    @yamachu
    yamachu committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    1252f20 View commit details
    Browse the repository at this point in the history