Electronのmain processで直接動作するコード以外からelectronに関する型を排除する #1278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MessageBoxも実際はどのボタンを押されたかのindexだけ欲しいはずなので、定義したinterfaceはもう少し小さくても良い
yamachu
commented
Apr 4, 2023
.eslintrc.js
Outdated
| @@ -52,6 +52,18 @@ module.exports = { | |||
| }, | |||
| ], | |||
| "import/order": "error", | |||
| "no-restricted-imports": [ | |||
There was a problem hiding this comment.
Hiroshiba
reviewed
Apr 4, 2023
Co-authored-by: Hiroshiba <hihokaruta@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
Electron非依存でEditorUIを動作させるのに、型的にも非依存であることが示されていると進めやすいため、型の調整を行いました。
また今後electronのモジュールをimportしてしまわぬようにlintでも弾くようにしています。
関連 Issue
ref: #1204
スクリーンショット・動画など
その他