Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

コンポーネントのrefを追加する関数の型を修正 #1273

Merged
merged 1 commit into from
Apr 3, 2023
Merged

コンポーネントのrefを追加する関数の型を修正 #1273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/components/AudioDetail.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,6 +264,7 @@ import {
onUnmounted,
reactive,
ref,
VNodeRef,
watch,
} from "vue";
import { useQuasar } from "quasar";
Expand Down Expand Up @@ -529,8 +530,8 @@ const nowPlayingContinuously = computed(

const audioDetail = ref<HTMLElement>();
let accentPhraseElems: HTMLElement[] = [];
const addAccentPhraseElem = (elem: HTMLElement) => {
if (elem) {
const addAccentPhraseElem: VNodeRef = (elem) => {
if (elem instanceof HTMLElement) {
accentPhraseElems.push(elem);
Comment on lines +533 to 535
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

こちらも同じエラーが出ていたので修正しました
こっちはHTMLElementを期待しているのでちょっとシンプル

}
};
Expand Down
12 changes: 6 additions & 6 deletions src/views/EditorHome.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@

<script setup lang="ts">
import path from "path";
import { computed, onBeforeUpdate, onMounted, ref, watch } from "vue";
import { computed, onBeforeUpdate, onMounted, ref, VNodeRef, watch } from "vue";
import draggable from "vuedraggable";
import { QResizeObserver, useQuasar } from "quasar";
import cloneDeep from "clone-deep";
Expand Down Expand Up @@ -353,12 +353,12 @@ const updateAudioDetailPane = async (height: number) => {
audioDetailPaneHeight.value = height;
await updateSplitterPosition("audioDetailPaneHeight", height);
};

// component
let audioCellRefs: Record<AudioKey, typeof AudioCell> = {};
const addAudioCellRef = (audioCellRef: typeof AudioCell) => {
if (audioCellRef) {
audioCellRefs[audioCellRef.audioKey] = audioCellRef;
let audioCellRefs: Record<AudioKey, InstanceType<typeof AudioCell>> = {};
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

子コンポーネントの参照を保持するときは InstanceType を使うべきだそうなので変更しています
https://ja.vuejs.org/guide/typescript/composition-api.html#typing-component-template-refs

const addAudioCellRef: VNodeRef = (audioCellRef) => {
if (audioCellRef && !(audioCellRef instanceof Element)) {
const typedAudioCellRef = audioCellRef as InstanceType<typeof AudioCell>;
audioCellRefs[typedAudioCellRef.audioKey] = typedAudioCellRef;
}
};
onBeforeUpdate(() => {
Expand Down