コンポーネントのrefを追加する関数の型を修正 #1273
Merged
コンポーネントのrefを追加する関数の型を修正 #1273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-chop
commented
Apr 1, 2023
| const addAudioCellRef = (audioCellRef: typeof AudioCell) => { | ||
| if (audioCellRef) { | ||
| audioCellRefs[audioCellRef.audioKey] = audioCellRef; | ||
| let audioCellRefs: Record<AudioKey, InstanceType<typeof AudioCell>> = {}; |
There was a problem hiding this comment.
子コンポーネントの参照を保持するときは InstanceType を使うべきだそうなので変更しています
https://ja.vuejs.org/guide/typescript/composition-api.html#typing-component-template-refs
k-chop
commented
Apr 1, 2023
Comment on lines
+533
to
535
| const addAccentPhraseElem: VNodeRef = (elem) => { | ||
| if (elem instanceof HTMLElement) { | ||
| accentPhraseElems.push(elem); |
There was a problem hiding this comment.
こちらも同じエラーが出ていたので修正しました
こっちはHTMLElementを期待しているのでちょっとシンプル
y-chan
approved these changes
Apr 3, 2023
Hiroshiba
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
refの型定義はこうなっています。addAudioCellRefの型は(audioCellRef: typeof AudioCell) => voidです。（typeof AudioCell ≒ ComponenPublicInstance）これが
(ref: Element | ComponentPublicInstance | null, refs: Record<string, any>) => voidと互換性がなくエラーになっていました（
(A | B) => voidを要求しているところにA => voidは入れられない。(A => void) | (B => void)ならOK）addAudioCellRefの型はVNodeRefにしておき、中で型の絞り込みを行っています。また、
AudioCellであることも分からないのでtype assertionしています。<audio-cell>コンポーネントのrefを指定しているんだからvueが推論して欲しい気もしますね・・・関連 Issue