-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
実装:MinimumEngineManifest格納時の検証をZodで行う #1186
Merged
Merged
Changes from 3 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
713958e
実装:MinimumEngineManifest格納時の検証をZodで行う ref #1181
nmori dde98eb
レビュー結果の反映 ref #1186
nmori dfcfcd9
レビュー結果の反映2
nmori 1e0ab69
* レビュー結果の反映3
nmori dd7a6d5
変名に失敗していた部分の修正
nmori 06de130
コンフリクトの修正
nmori e73fef4
コンフリクトの修正
nmori 762ade4
Merge branch 'Branch_4d3e408c' of https://github.com/nmori/voicevox i…
nmori bb00ebb
変更すべきではないものまで入ってしまった。コミットを打ち消す
nmori 80e6233
Update src/type/preload.ts
Hiroshiba File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -1,6 +1,7 @@ | ||||||
import { IpcRenderer, IpcRendererEvent, nativeTheme } from "electron"; | ||||||
import { IpcSOData } from "./ipc"; | ||||||
import { z } from "zod"; | ||||||
import { EngineManifest } from "@/openapi"; | ||||||
|
||||||
export const isMac = process.platform === "darwin"; | ||||||
// ホットキーを追加したときは設定のマイグレーションが必要 | ||||||
|
@@ -280,12 +281,23 @@ export type DefaultStyleId = { | |||||
defaultStyleId: number; | ||||||
}; | ||||||
|
||||||
export type MinimumEngineManifest = { | ||||||
name: string; | ||||||
uuid: string; | ||||||
command: string; | ||||||
port: string; | ||||||
}; | ||||||
export const supportedFeaturesItemSchema = z.object({ | ||||||
type: z.string(), | ||||||
value: z.boolean(), | ||||||
name: z.string(), | ||||||
}); | ||||||
|
||||||
export const minimumEngineManifest = z | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ここもSchemaだと統一感あるかもです
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. あ、ここ忘れられてるかもです! |
||||||
.object({ | ||||||
name: z.string(), | ||||||
uuid: z.string(), | ||||||
Hiroshiba marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
command: z.string(), | ||||||
port: z.number(), | ||||||
supported_features: z.record(z.string(), supportedFeaturesItemSchema), // FIXME:JSON側はsnake_caseなので合わせているが、camelCaseに修正する | ||||||
}) | ||||||
.passthrough(); | ||||||
|
||||||
export type MinimumEngineManifest = z.infer<typeof minimumEngineManifest>; | ||||||
|
||||||
export type EngineInfo = { | ||||||
uuid: string; | ||||||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ここ
'EngineManifest' is defined but never used
と出てたので消しちゃっても良さそうです!