実装：MinimumEngineManifest格納時の検証をZodで行う #1186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
reviewed
Feb 7, 2023
Hiroshiba
reviewed
Feb 7, 2023
Hiroshiba
reviewed
Feb 7, 2023
Hiroshiba
reviewed
Feb 7, 2023
src/type/preload.ts
Outdated
| }; | ||
|
|
||
| export const minimumEngineManifest = z |
There was a problem hiding this comment.
ここもSchemaだと統一感あるかもです
Suggested change
| export const minimumEngineManifest = z | |
| export const minimumEngineManifestSchema = z |
Hiroshiba
reviewed
Feb 7, 2023
Hiroshiba
reviewed
Feb 7, 2023
|
ありがとうございます！ |
Hiroshiba
reviewed
Feb 8, 2023
Hiroshiba
reviewed
Feb 9, 2023
src/type/preload.ts
Outdated
| @@ -1,6 +1,7 @@ | |||
| import { IpcRenderer, IpcRendererEvent, nativeTheme } from "electron"; | |||
| import { IpcSOData } from "./ipc"; | |||
| import { z } from "zod"; | |||
| import { EngineManifest } from "@/openapi"; | |||
There was a problem hiding this comment.
ここ'EngineManifest' is defined but never usedと出てたので消しちゃっても良さそうです！
Suggested change
| import { EngineManifest } from "@/openapi"; |
|
こちらのコメントどうでしょう 👀 （重要ではないのでそのままでも大丈夫です！） あとコンフリクトが発生していそうです 🙇♂️ |
* 命名規則の適用（スキーマ） * 不要な参照の削除
…nto Branch_4d3e408c
* EngineManageDialog.vue
|
途中までうまくいってたとおもったのですが |
Hiroshiba
approved these changes
Feb 10, 2023
Hiroshiba
reviewed
Feb 10, 2023
|
問題ないと思うのでマージします！！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
・エンジン追加時および起動時のminimumEngineManifestを Zodで検証してから格納する
・検証に当たり、portの型が異なるようにみえたので修正(string→number)
関連 Issue
ref #1181
スクリーンショット・動画など
その他