fix(Byte): hexValidator should remove leading 0 #717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A leading 0 in the hex string can throw off the hex validator, since this information is lost in the parseInt action. This results in the string check to return `false` instead of `true`, because the parsed hex string does not contain the leading 0.
|
Thanks @rufman ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A leading 0 in the hex string can throw off the hex validator, since
this information is lost in the parseInt action. This results in the
string check to return
falseinstead oftrue, because the parsedhex string does not contain the leading 0.
Related #716
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Added a test for a hex string containing a leading 0 (
'04080f10172a')Test Environment:
Checklist: