fix(Byte): update isHex validator #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The base64 and hex validators are not guaranteeed to work. There are some false positive cases, so instead add a type header to the string, so a user can specify what the encoding of the string is.
|
Is there anything else that is needed for this PR to be mergeable? |
|
Isn't that a breaking change? |
|
Well it changes the functionality, yes. But the previous parsing didn't work in subtle ways. |
|
Instead of breaking the existing ones, we can have a better unit tests or two different scalars like one for Hex and another one for Base64. What do you think? |
|
Yeah I can create 2 new Byte scalars. But would we deprecate |
There were cases where the hex regex validator would return true for a value that was acutally base64 encoded. Added tests for this case and updated the validator.
|
I was able to fix the hex validator, which would sometime return true for base64 values. |
rufman
changed the title
|
|
|
@rufman Something is wrong with the const buf = Buffer.from([4, 8, 15, 16, 23, 42]);
const hex = buf.toString("hex");
console.log(hex); // 04080f10172a
console.log(hexValidator(hex)); // false |
|
Hmm leading 0 is the issue. fix is here: #717 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The base64 and hex validators are not guaranteeed to work.
There are some false positive cases, so instead add a type header to
the string, so a user can specify what the encoding of the string is.