Skip to content

[runtime] Magic interfaces requires the complex stelemref to handle a… #1296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2020
Merged

[runtime] Magic interfaces requires the complex stelemref to handle a… #1296

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions mono/metadata/marshal.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9837,6 +9837,11 @@ get_virtual_stelemref_kind (MonoClass *element_class)
return STELEMREF_OBJECT;
if (is_monomorphic_array (element_class))
return STELEMREF_SEALED_CLASS;

/* magic ifaces requires aditional checks for when the element type is an array */
if (MONO_CLASS_IS_INTERFACE (element_class) && element_class->is_array_special_interface)
return STELEMREF_COMPLEX;

/* Compressed interface bitmaps require code that is quite complex, so don't optimize for it. */
if (MONO_CLASS_IS_INTERFACE (element_class) && !mono_class_has_variant_generic_params (element_class))
#ifdef COMPRESSED_INTERFACE_BITMAP
Expand Down
25 changes: 25 additions & 0 deletions mono/mini/objects.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
using System;
using System.Text;
using System.Reflection;
using System.Collections.Generic;
using System.Runtime.InteropServices;
using System.Runtime.CompilerServices;

Expand Down Expand Up @@ -1829,6 +1830,30 @@ public static int test_0_typedref () {

return 0;
}

public interface IFoo
{
int MyInt { get; }
}

public class IFooImpl : IFoo
{
public int MyInt => 0;
}

//gh 6266
public static int test_0_store_to_magic_iface_array ()
{
ICollection<IFoo> arr1 = new IFooImpl[1] { new IFooImpl() };
ICollection<IFoo> arr2 = new IFooImpl[1] { new IFooImpl() };

ICollection<IFoo>[] a2d = new ICollection<IFoo>[2] {
arr1,
arr2,
};

return 0;
}
}

#if __MOBILE__
Expand Down