Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Draft] 日常招新 #26

Closed
wants to merge 282 commits into from
Closed

[Draft] 日常招新 #26

wants to merge 282 commits into from

Conversation

winderica
Copy link
Collaborator

@winderica winderica commented Nov 7, 2020 •
edited
Loading

待讨论的问题：

  • 日常招新的英文
  • 只有一个日常招新 or 每年都可以有一个日常招新
  • 在秋招/春招/夏令营时间段，日常招新是否有效

联动：

colinaaa and others added 15 commits September 28, 2020 09:51
@colinaaa
chore: apply mui rename to avoid warning in console
1bbac73
@colinaaa
feat(dark-mode): overrides default text color in button
3da5210 
for better reading experience
@ttzztztz
Create LICENSE
179352e
@ManiaciaChao
Merge pull request #17 from colinaaa/feat/dark-mode
9290bc9 
feat(dark-mode): implement basic dark mode
@colinaaa
feat(login): use onSubmit on form and type=submit on button to submit…
75bf3c5 
… when press enter

note that click on submit button will emit a onsubmit event

re #21
@colinaaa
feat(dark-mode): override the checked checkbox styles
ea208ac 
inherit the root color of checkbox
@colinaaa
style: add missing comma
fccef73 
maybe we should use formatter tools and lint tools
@colinaaa
Merge pull request #22 from colinaaa/feat/login
923afba 
feat: Press enter to login
@colinaaa
Merge pull request #23 from colinaaa/style/checkbox
43bd591 
feat(dark-mode): override the checked checkbox styles
@colinaaa
style: add prettier and husky to enforce code style
9c9f64d 
I tried my best to remain current code style, and not using eslint since CRA include it as default

re #19
@colinaaa
style: resolve confilct between tools and master
eca39f5
@colinaaa
feat(dark-mode): override default primary color of IconButton
69704c0 
make IconButton visiable under dark mode
@colinaaa
feat(set-admin): implement set admin
eb38b4e 
dont allow admin to unset admin, self tested well
@colinaaa
Merge pull request #24 from colinaaa/feat/setAdmin
20859e0 
feat(set-admin): implement set admin
@winderica
Update: 日常招新
a8d038d
@ManiaciaChao
Copy link
Contributor

ManiaciaChao commented Nov 7, 2020 •
edited
Loading

on "在秋招/春招/夏令营时间段，日常招新是否有效":
如果在秋招时开放日常招新，就需要两个表单。而且这样的日常招新显然应该合入秋招。我的意见是，除了秋春夏招新前一段时间（防止分流提前报名的选手），报名通道开放，算日常招新。

@wangnengjie
Copy link
Contributor

  • normal？
  • 每年一个日常招新的话可能时间线上会清晰一点？hr dashboard那边每年日常招新的选手全堆在一次招新里似乎也不太好。另外不清楚后台设计起来怎么样。
  • ...我的意见是无效，两个入口的话该怎么设计？不过等秋招/春招/夏令营关闭以后，一些没来得及报的直接往日常招新报，要怎么处理？好像也挺麻烦的。

@ManiaciaChao ，这次要做选手dashboard的话，可以让PM那边考虑一下流程？目前日常招新对内只是个提议，对外尚没有什么说法。

@ManiaciaChao
Copy link
Contributor

英文的话，感觉我们的“normal”是秋招春招，反而“日常招新”是计划外的。unscheduled 或者 flexible 可能更符合语义？ @wangnengjie

ttzztztz
ttzztztz approved these changes Nov 8, 2020
View reviewed changes
Copy link
Contributor

@ttzztztz ttzztztz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ttzztztz ttzztztz self-assigned this Nov 8, 2020
@winderica winderica closed this Jun 5, 2021
@winderica winderica deleted the feat/日常招新 branch June 5, 2021 12:47
winderica added a commit that referenced this pull request Jun 7, 2021
@winderica
Fix: fix #26
f3ec0ee 
No response is still a response
winderica added a commit that referenced this pull request Jun 7, 2021
@winderica
Fix: close #26
7fbea21 
Finally I figured out a backward compatible solution of password verification
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttzztztz ttzztztz ttzztztz approved these changes

@ManiaciaChao ManiaciaChao ManiaciaChao approved these changes

@colinaaa colinaaa Awaiting requested review from colinaaa

@wangnengjie wangnengjie Awaiting requested review from wangnengjie

Assignees

@ttzztztz ttzztztz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@winderica @ManiaciaChao @wangnengjie @ttzztztz @colinaaa