Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] v3 #19

Closed
wants to merge 591 commits into from
Closed

[WIP] v3 #19

wants to merge 591 commits into from

Conversation

winderica
Copy link
Collaborator

@winderica winderica commented Jul 8, 2020

没精力维护了,项目由 @ManiaciaChao 接锅

  • Bugs and PRs
  • Polish UI
  • Code style unification
    • prettier, linter, etc
  • State management
    • v2的时候,redux还没有很好地支持hooks,所以写出来个缝合怪。可以选择继续使用redux,或者试一下mobx,最近在别的项目试了下后者,能够显著降低心智负担
  • Performance
    • 在候选人多的时候laggy,试过virtualized,效果不是很好
  • API
    • 当初设计的各种不合理
  • CI/CD

(考虑到提交记录的可读性,dev分支是squash过的)

@winderica
Copy link
Collaborator Author

我把当前版本部署在了http://10.12.164.179:7341,校园网访问即可体验。之后只会有bug fixes,欢迎反馈。

目前已知的问题:

  • 有些组件没加memo,会被意外地重新渲染
  • 有的样式还没有适配移动端

@winderica winderica closed this Jun 5, 2021
winderica pushed a commit that referenced this pull request Jun 5, 2021
I tried my best to remain current code style, and not using eslint since CRA include it as default

re #19
winderica pushed a commit that referenced this pull request Jun 5, 2021
Change Log

- use alias for human-readability
- implement setAdmin
@winderica winderica deleted the dev branch June 5, 2021 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants