Remove BASS Audio Decoder #955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a massive step forward, thanks a ton for digging deep into this! |
barbeque-squared
approved these changes
Feb 5, 2025
This was referenced Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by #954. This is the second of two PRs intended to resolve USDX's audio seeking accuracy issues (#673, #749, #884).
This PR removes the BASS audio decoder that is used by the Windows version for most audio file formats, and harmonizes all platforms around the FFmpeg audio decoder. This has been previously discussed in #750 and #936.
The FFmpeg audio decoder (with #954 incorporated) meets or exceeds the capabilities of the BASS audio decoder. The BASS audio decoder's seeking is less accurate for most file formats, and there is no realistic path to improvement since BASS is a non-free, closed source library.
USDX's built-in editor relies on precise and accurate audio seeking. Currently, you can edit a .txt file with the USDX editor and get different results depending on the platform, because they are using different audio backends. This PR will eliminate that, so setting the
#GAPwill have the same result regardless of platform. It's important to consider the impact to the ecosystem, such as .txt files hosted in USDB. It's a big problem if the timing of the .txt file varies by platform.Fixes #673
Fixes #749
Fixes #884