Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FN-3163): MDM endpoints for automatically creating new DTFS customers in Salesforce (Dun and Bradstreet service only) #1056

Closed
wants to merge 12 commits into from

Conversation

natdeanlewissoftwire
Copy link
Contributor

@natdeanlewissoftwire natdeanlewissoftwire commented Nov 8, 2024

Introduction ✏️

As part of the CCM project, if a customer does exist in SF, we are automatically creating it rather than relying on the manual process currently undertaken by Business Support Group. DTFS will send requests to a new customer/salesforce endpoint for MDM to create a customer in Salesforce. Technical documentation of this process is here

The corresponding feature-flagged DTFS pull request is here

Resolution ✔️

This PR adds the Dun and Bradstreet service, and an endpoint to allow us to GET a company from Dun and Bradstreet by their registration number (in our case Companies House Number). This will then be used by this PR as part of the customer creation process.

Miscellaneous ➕

To be merged before this PR

@natdeanlewissoftwire natdeanlewissoftwire changed the base branch from create-customer-endpoint to main November 8, 2024 16:55
@natdeanlewissoftwire natdeanlewissoftwire changed the title feat: add DnB behaviour ready for use in customers service feat(FN-3163): MDM endpoints for automatically creating new DTFS customers in Salesforce (Dun and Bradstreet service only) Nov 8, 2024
@natdeanlewissoftwire natdeanlewissoftwire force-pushed the create-customer-endpoint-dnb-service branch from 774e377 to 4cf255c Compare November 27, 2024 08:53
@natdeanlewissoftwire natdeanlewissoftwire changed the base branch from main to staging December 3, 2024 16:21
@natdeanlewissoftwire natdeanlewissoftwire changed the base branch from staging to main December 3, 2024 16:22
@natdeanlewissoftwire natdeanlewissoftwire marked this pull request as ready for review December 3, 2024 16:56
Copy link
Contributor

@avaitonis avaitonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nitpicks and question about logs.

src/main.module.ts Outdated Show resolved Hide resolved
src/main.module.ts Show resolved Hide resolved
Copy link

sonarqubecloud bot commented Jan 6, 2025

@natdeanlewissoftwire natdeanlewissoftwire deleted the create-customer-endpoint-dnb-service branch January 6, 2025 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants