generated from UK-Export-Finance/nestjs-template
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(FN-3163): MDM endpoints for automatically creating new DTFS customers in Salesforce (Dun and Bradstreet service only) #1056
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natdeanlewissoftwire
changed the base branch from
create-customer-endpoint
to
main
November 8, 2024 16:55
natdeanlewissoftwire
changed the title
feat: add DnB behaviour ready for use in customers service
feat(FN-3163): MDM endpoints for automatically creating new DTFS customers in Salesforce (Dun and Bradstreet service only)
Nov 8, 2024
natdeanlewissoftwire
force-pushed
the
create-customer-endpoint-dnb-service
branch
from
November 27, 2024 08:53
774e377
to
4cf255c
Compare
natdeanlewissoftwire
had a problem deploying
to
qa
November 27, 2024 08:53 — with
GitHub Actions
Failure
natdeanlewissoftwire
had a problem deploying
to
qa
November 27, 2024 08:53 — with
GitHub Actions
Failure
natdeanlewissoftwire
had a problem deploying
to
qa
November 27, 2024 08:53 — with
GitHub Actions
Failure
natdeanlewissoftwire
had a problem deploying
to
qa
November 27, 2024 08:53 — with
GitHub Actions
Failure
natdeanlewissoftwire
had a problem deploying
to
qa
November 27, 2024 08:53 — with
GitHub Actions
Failure
natdeanlewissoftwire
had a problem deploying
to
qa
December 3, 2024 16:37 — with
GitHub Actions
Failure
natdeanlewissoftwire
had a problem deploying
to
qa
December 3, 2024 16:37 — with
GitHub Actions
Failure
natdeanlewissoftwire
had a problem deploying
to
qa
December 3, 2024 16:37 — with
GitHub Actions
Failure
natdeanlewissoftwire
had a problem deploying
to
qa
December 3, 2024 16:37 — with
GitHub Actions
Failure
natdeanlewissoftwire
had a problem deploying
to
qa
December 3, 2024 16:37 — with
GitHub Actions
Failure
natdeanlewissoftwire
had a problem deploying
to
qa
December 5, 2024 15:03 — with
GitHub Actions
Failure
natdeanlewissoftwire
had a problem deploying
to
qa
December 5, 2024 15:03 — with
GitHub Actions
Failure
natdeanlewissoftwire
had a problem deploying
to
qa
December 5, 2024 15:03 — with
GitHub Actions
Failure
natdeanlewissoftwire
had a problem deploying
to
qa
December 5, 2024 15:03 — with
GitHub Actions
Failure
natdeanlewissoftwire
had a problem deploying
to
qa
December 5, 2024 15:03 — with
GitHub Actions
Failure
natdeanlewissoftwire
had a problem deploying
to
qa
December 5, 2024 15:07 — with
GitHub Actions
Failure
natdeanlewissoftwire
had a problem deploying
to
qa
December 5, 2024 15:07 — with
GitHub Actions
Failure
natdeanlewissoftwire
had a problem deploying
to
qa
December 5, 2024 15:07 — with
GitHub Actions
Failure
natdeanlewissoftwire
had a problem deploying
to
qa
December 5, 2024 15:07 — with
GitHub Actions
Failure
natdeanlewissoftwire
had a problem deploying
to
qa
December 5, 2024 15:07 — with
GitHub Actions
Failure
avaitonis
reviewed
Dec 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nitpicks and question about logs.
src/helper-modules/dun-and-bradstreet/dun-and-bradstreet.service.test.ts
Outdated
Show resolved
Hide resolved
src/helper-modules/dun-and-bradstreet/exception/dun-and-bradstreet.exception.test.ts
Outdated
Show resolved
Hide resolved
natdeanlewissoftwire
force-pushed
the
create-customer-endpoint-dnb-service
branch
from
January 6, 2025 09:51
f9c18fc
to
a2f5db5
Compare
natdeanlewissoftwire
had a problem deploying
to
qa
January 6, 2025 09:51 — with
GitHub Actions
Failure
natdeanlewissoftwire
had a problem deploying
to
qa
January 6, 2025 09:51 — with
GitHub Actions
Failure
natdeanlewissoftwire
had a problem deploying
to
qa
January 6, 2025 09:51 — with
GitHub Actions
Failure
natdeanlewissoftwire
had a problem deploying
to
qa
January 6, 2025 09:51 — with
GitHub Actions
Failure
natdeanlewissoftwire
had a problem deploying
to
qa
January 6, 2025 09:51 — with
GitHub Actions
Failure
Quality Gate passedIssues Measures |
natdeanlewissoftwire
temporarily deployed
to
qa
January 6, 2025 11:13 — with
GitHub Actions
Inactive
natdeanlewissoftwire
temporarily deployed
to
qa
January 6, 2025 11:13 — with
GitHub Actions
Inactive
natdeanlewissoftwire
temporarily deployed
to
qa
January 6, 2025 11:13 — with
GitHub Actions
Inactive
natdeanlewissoftwire
temporarily deployed
to
qa
January 6, 2025 11:13 — with
GitHub Actions
Inactive
natdeanlewissoftwire
had a problem deploying
to
qa
January 6, 2025 11:13 — with
GitHub Actions
Failure
natdeanlewissoftwire
had a problem deploying
to
qa
January 6, 2025 11:16 — with
GitHub Actions
Failure
natdeanlewissoftwire
had a problem deploying
to
qa
January 6, 2025 11:17 — with
GitHub Actions
Failure
natdeanlewissoftwire
had a problem deploying
to
qa
January 6, 2025 11:23 — with
GitHub Actions
Failure
natdeanlewissoftwire
had a problem deploying
to
qa
January 6, 2025 11:23 — with
GitHub Actions
Failure
natdeanlewissoftwire
temporarily deployed
to
qa
January 6, 2025 11:25 — with
GitHub Actions
Inactive
natdeanlewissoftwire
had a problem deploying
to
qa
January 6, 2025 11:25 — with
GitHub Actions
Failure
natdeanlewissoftwire
temporarily deployed
to
qa
January 6, 2025 11:25 — with
GitHub Actions
Inactive
natdeanlewissoftwire
temporarily deployed
to
qa
January 6, 2025 11:25 — with
GitHub Actions
Inactive
natdeanlewissoftwire
temporarily deployed
to
qa
January 6, 2025 11:25 — with
GitHub Actions
Inactive
natdeanlewissoftwire
temporarily deployed
to
qa
January 6, 2025 11:29 — with
GitHub Actions
Inactive
natdeanlewissoftwire
temporarily deployed
to
qa
January 6, 2025 11:29 — with
GitHub Actions
Inactive
natdeanlewissoftwire
temporarily deployed
to
qa
January 6, 2025 11:29 — with
GitHub Actions
Inactive
natdeanlewissoftwire
temporarily deployed
to
qa
January 6, 2025 11:29 — with
GitHub Actions
Inactive
natdeanlewissoftwire
temporarily deployed
to
qa
January 6, 2025 11:29 — with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction ✏️
As part of the CCM project, if a customer does exist in SF, we are automatically creating it rather than relying on the manual process currently undertaken by Business Support Group. DTFS will send requests to a new customer/salesforce endpoint for MDM to create a customer in Salesforce. Technical documentation of this process is here
The corresponding feature-flagged DTFS pull request is here
Resolution ✔️
This PR adds the Dun and Bradstreet service, and an endpoint to allow us to GET a company from Dun and Bradstreet by their registration number (in our case Companies House Number). This will then be used by this PR as part of the customer creation process.
Miscellaneous ➕
To be merged before this PR