feat(FN-3163): Create new DTFS exporters in Salesforce #4021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
December 3, 2024 08:52
This was referenced Dec 3, 2024
natdeanlewissoftwire
changed the title
natdeanlewissoftwire
requested review from
abhi-markan,
ttbarnes and
ChristianMcc
abhi-markan
requested changes
Dec 19, 2024
trade-finance-manager-api/src/v1/controllers/deal.party-db.test.js
Outdated
Show resolved
Hide resolved
trade-finance-manager-api/src/v1/controllers/deal.party-db.test.js
Outdated
Show resolved
Hide resolved
trade-finance-manager-api/src/v1/controllers/deal.party-db.test.js
Outdated
Show resolved
Hide resolved
added 8 commits
December 19, 2024 14:13
trade-finance-manager-api/src/v1/controllers/deal.party-db.test.js
Outdated
Show resolved
Hide resolved
abhi-markan
reviewed
Dec 20, 2024
trade-finance-manager-api/src/v1/controllers/deal.party-db.test.js
Outdated
Show resolved
Hide resolved
abhi-markan
requested changes
Dec 20, 2024
trade-finance-manager-api/src/v1/controllers/deal.party-db.test.js
Outdated
Show resolved
Hide resolved
|
abhi-markan
merged commit 5b07601
into
feat/FN-3163/create-new-dtfs-customers-in-sf
4 of 5 checks passed
abhi-markan
deleted the
feat/FN-3163/create-new-dtfs-customer-in-sf-informatica
branch
abhi-markan
pushed a commit
to UK-Export-Finance/mdm-api
that referenced
this pull request
Jan 8, 2025
… service only) (#1130) ## Introduction ✏️ As part of the CCM project, if a customer does exist in SF, we are automatically creating it rather than relying on the manual process currently undertaken by Business Support Group. DTFS will send requests to a new customer/salesforce endpoint for MDM to create a customer in Salesforce. Technical documentation of this process is [here](https://ukef.sharepoint.com/:w:/r/sites/pmo-PRO211/Shared%20Documents/1.%20TO%20USE%20New%20file%20plan/2.%20Tranche%202/03.%20Customer%20and%20Credit%20Migration/Documents/DTFS%20%26%20Salesforce%20Integration/DTFS%20-%20SF%20Integration%20Technical%20Details.docx?d=w75ec8ca455ec492db2a912cc20cea7e7&csf=1&web=1&e=rhuzKr) The corresponding feature-flagged DTFS pull request is [here](UK-Export-Finance/dtfs2#4021) ## Resolution ✔️ This PR adds the Dun and Bradstreet service, and an endpoint to allow us to GET a company from Dun and Bradstreet by their registration number (in our case Companies House Number). This will then be used by [this PR](#1057) as part of the customer creation process. ## Miscellaneous ➕ To be merged before the remainder of the customer creation endpoint. Also adds a user facing D&B endpoint, viewable in the Swagger docs:  --------- Co-authored-by: Nat Dean-Lewis <ndlewis@ukexportfinance.gov.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction ✏️
As part of the CCM project, if a customer does not exist in Salesforce, we are automatically creating it rather than relying on the manual process currently undertaken by Business Support Group. This change sends a request to a new createParty endpoint that will be merged in to the MDM codebase.
Tech docs of the full process are available here
Resolution ✔️
Feature flagged for now:
Send a "get or create" request to APIM, which handles all the logic. The creation process involves querying Salesforce via Informatica, getting a DUNS number, generating a PartyURN or using a legacy one and then returning the created customer to DTFS so the URN can be assigned to the new deal in TFM.
Miscellaneous ➕
Increase the deal submission timeout to 30 seconds to allow this process to consistently succeed. This won't be necessary once the deal submission is handled by background processes as discussed in the root README.