Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(EMS-531, 536, 551, 524): various copy issues #162

Merged
merged 12 commits into from
Nov 21, 2022

Conversation

ttbarnes
Copy link
Contributor

@ttbarnes ttbarnes commented Nov 18, 2022

This PR fixes or adds various copy/field hints in insurance eligibility and shared pages in quote and insurance eligibility.

  • Fix/add hint to “pre credit” period form used in insurance eligibility.
  • Fix/update both instances of “exporter location” page/field to use the same, new title.
  • Fix/update error message used in “minimum UK goods or services” form.
  • Fix/add hint to “minimum UK goods or services” form in insurance eligibility.
  • Remove now unused test in quote - buyer country controller after merging main into main-application

@ttbarnes ttbarnes added the bug Something isn't working label Nov 18, 2022
@ttbarnes ttbarnes temporarily deployed to dev November 18, 2022 15:23 Inactive
@ttbarnes ttbarnes temporarily deployed to dev November 18, 2022 15:23 Inactive
@ttbarnes ttbarnes temporarily deployed to dev November 18, 2022 15:23 Inactive
@ttbarnes ttbarnes temporarily deployed to dev November 18, 2022 15:23 Inactive
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
71.0% 71.0% Duplication

@ttbarnes ttbarnes merged commit 818beaf into main-application Nov 21, 2022
@ttbarnes ttbarnes deleted the fix/various branch November 21, 2022 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant