Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(EMS-379): fix issue where buyer country would not update when JS is disabled #141

Merged
merged 2 commits into from
Oct 27, 2022

Conversation

ttbarnes
Copy link
Contributor

@ttbarnes ttbarnes commented Oct 27, 2022

This PR fixes an issue where buyer country would not update in a 'change answer' scenario if JS is disabled.

Summary of changes

  • Remove COUNTRY field id, use BUYER_COUNTRY instead.
  • Simplify buyer country controller and validation logic for getting the submitted country when JS is enabled or disabled.
  • Remove client side JS onConfirm function for when a country is selected via autocomplete component.

@ttbarnes ttbarnes added the bug Something isn't working label Oct 27, 2022
@ttbarnes ttbarnes temporarily deployed to dev October 27, 2022 12:21 Inactive
@ttbarnes ttbarnes temporarily deployed to dev October 27, 2022 12:21 Inactive
@ttbarnes ttbarnes temporarily deployed to dev October 27, 2022 12:43 Inactive
@ttbarnes ttbarnes temporarily deployed to dev October 27, 2022 12:43 Inactive
@ttbarnes ttbarnes temporarily deployed to dev October 27, 2022 12:43 Inactive
@ttbarnes ttbarnes marked this pull request as ready for review October 27, 2022 12:43
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
25.0% 25.0% Duplication

@ttbarnes ttbarnes temporarily deployed to dev October 27, 2022 12:53 Inactive
@ttbarnes ttbarnes temporarily deployed to dev October 27, 2022 12:53 Inactive
@ttbarnes ttbarnes temporarily deployed to dev October 27, 2022 12:53 Inactive
@ttbarnes ttbarnes temporarily deployed to dev October 27, 2022 12:53 Inactive
@ttbarnes ttbarnes merged commit 397378b into main Oct 27, 2022
@ttbarnes ttbarnes deleted the fix/EMS-379 branch October 27, 2022 13:34
ttbarnes added a commit that referenced this pull request Nov 21, 2022
* fix(EMS-379): fix issue where buyer country would not update when JS is disabled (#141)

* fix(EMS-379): fix issue where buyer country would not update in a 'change answer' scenario if JS is disabled

* fix(EMS-379): update e2e tests to check autocomplete value instead of hidden input value

* chore(main): release 1.14.3

* fix(EMS-378): update Content-Security-Policy to allow GA scripts

* chore(main): release 1.14.4

* fix(EMS-524): update heading/page title for exporter location pages

* fix(EMS-531): add hint to insurance eligibility - uk goods or services form

* fix(EMS-536): fix/update error message for uk goods or services form

* fix(EMS-551): add hint to pre-credit period form in insurance eligibility

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant