Skip to content

fix(ui5-badge): fix icon size #729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 13, 2019
Merged

fix(ui5-badge): fix icon size #729

merged 4 commits into from
Aug 13, 2019

Conversation

ilhan007
Copy link
Contributor

@ilhan007 ilhan007 commented Aug 13, 2019 •
edited
Loading

  • fix the icon size, after using SVG, instead of icon-font
  • enable component scaling based on the set font-size, using em, instead of rem.

@ilhan007 ilhan007 changed the title fix(ui5-badge): icon size fix(ui5-badge): fix icon size Aug 13, 2019
@ilhan007 ilhan007 requested review from pskelin and MapTo0 August 13, 2019 07:49
pskelin
pskelin reviewed Aug 13, 2019
View reviewed changes
packages/main/src/themes/base/Badge-parameters.css Outdated
@@ -1,4 +1,5 @@
:root {
--ui5-badge-font-size: 0.75em;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add comment which the original parameter was

@ilhan007 ilhan007 merged commit f1e1343 into master Aug 13, 2019
@ilhan007 ilhan007 deleted the fix-badge-icon-size branch August 13, 2019 12:43
@georgimkv georgimkv mentioned this pull request Jul 26, 2021
Merged
@dimovpetar dimovpetar mentioned this pull request Apr 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pskelin pskelin pskelin approved these changes

@MapTo0 MapTo0 Awaiting requested review from MapTo0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ilhan007 @pskelin