feat(u5-badge): implement SAP Horizon theme family #5143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| text-transform: uppercase; | ||
| letter-spacing: inherit; | ||
| font-size: var(--ui5-badge-font-size); /* origin from --sapFontSmallSize (0.75rem) */ | ||
| font-size: 0.75em; /* origin from --sapFontSmallSize (0.75rem) */ |
There was a problem hiding this comment.
Why don't we use the variable var(--sapFontSmallSize?
There was a problem hiding this comment.
Because it's in rem. Badge uses em since #729, I didn't want to change that
| border-radius: 0.5rem; | ||
| box-sizing: border-box; | ||
| font-family: "72override", var(--sapFontFamily); | ||
| font-weight: var(--_ui5-badge-font-weight); |
There was a problem hiding this comment.
shoudn't we use the variables, so it is easear for restyling later?
There was a problem hiding this comment.
I removed it because it's not used in any theme and only brings extra complexity
GerganaKremenska
previously approved these changes
May 3, 2022
georgimkv
approved these changes
May 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #5006