[CMake] install files in versioned locations (breaks backward compatibility for external projects!) #1358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This breaks backwards compatibility in some sense. New locations are indicated in the release notes.
This was referenced Feb 1, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This breaks backwards compatibility in some sense. New locations are indicated in the release notes. In particular, an external project now needs to set
STIR_DIRto/whereever/STIR/was/installed/lib/cmake/STIR-6.0.Unfortunately, this does not yet allow installing different STIR versions in the same location, as the static libraries and executables are unversioned. If you need this, you will need to install using different values for
CMAKE_INSTALL_PREFIX.As part of this change, I no longer use
STIR_CONFIG_DIRas a cached variable, such that it automatically moves along withCMAKE_INSTALL_PREFIX. However, if you are upgrading an existing STIR build, you might have to delete the cached variable, or it will point to the old location.Fixes #945